Re: [PATCH v2] um: add dummy ioremap and iounmap functions

From	Logan Gunthorpe <logang@deltatee.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] um: add dummy ioremap and iounmap functions
Date	2017-06-08 21:00 +0200
Message-ID	<tQaOZ-7W3-7@gated-at.bofh.it> (permalink)
References	<tL3br-1AL-11@gated-at.bofh.it> <tL3br-1AL-15@gated-at.bofh.it> <tL3l8-1E0-25@gated-at.bofh.it> <tLOk1-7u5-1@gated-at.bofh.it> <tLOtH-7xL-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Any thoughts on this? My patches for the other architectures are already
in linux-next. um is the only one that remains.

Thanks,

Logan

On 27/05/17 12:15 PM, Logan Gunthorpe wrote:
> Hi,
> 
> On 27/05/17 12:08 PM, Geert Uytterhoeven wrote:
>> Still, those code patch could be protected by #ifdef CONFIG_HAS_IOMEM,
>> or better, if (IS_ENABLED(CONFIG_HAS_IOMEM)).
> 
> Well I think it would have to be the former seeing the latter would
> still end up trying to compile the missing function. But having ifdefs
> inside code is not generally seen as good idea[1].
> 
> I'd really like to go forward with either this patch or something like
> it. The other two arches that have this problem are fine with merging a
> fix and adding ifdefs to work around a single arch doesn't feel right to me.
> 
> Thanks,
> 
> Logan
> 
> [1] http://yarchive.net/comp/linux/ifdefs.html
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] um: add dummy ioremap and iounmap functions Logan Gunthorpe <logang@deltatee.com> - 2017-06-08 21:00 +0200
  Re: [PATCH v2] um: add dummy ioremap and iounmap functions Richard Weinberger <richard@nod.at> - 2017-06-08 21:20 +0200

csiph-web