Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662214 > unrolled thread
| Started by | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2017-06-09 12:00 +0200 |
| Last post | 2017-06-10 16:50 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 12:00 +0200
Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs Anatolij Gustschin <agust@denx.de> - 2017-06-09 15:20 +0200
Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs stillcompiling@gmail.com - 2017-06-10 00:10 +0200
Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs Alan Tull <atull@kernel.org> - 2017-06-10 16:50 +0200
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-06-09 12:00 +0200 |
| Subject | Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs |
| Message-ID | <tQoRY-8lF-27@gated-at.bofh.it> |
On Mon, Jun 05, 2017 at 02:07:37PM -0500, Alan Tull wrote: > From: Joshua Clayton <stillcompiling@gmail.com> > > altera-ps-spi loads FPGA firmware over SPI, using the "passive serial" > interface on Altera Arria 10, Cyclone V or Stratix V FPGAs. > > This is one of the simpler ways to set up an FPGA at runtime. > The signal interface is close to unidirectional SPI with lsb first. > > Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> > Signed-off-by: Anatolij Gustschin <agust@denx.de> > Signed-off-by: Alan Tull <atull@kernel.org> I get the following build error with this patch: ERROR: "__spi_register_driver" [drivers/fpga/altera-ps-spi.ko] undefined! So I'll just ignore this whole series, can you fix these issues up and resend? thanks, greg k-h
[toc] | [next] | [standalone]
| From | Anatolij Gustschin <agust@denx.de> |
|---|---|
| Date | 2017-06-09 15:20 +0200 |
| Message-ID | <tQrZw-1Zf-17@gated-at.bofh.it> |
| In reply to | #1662214 |
On Fri, 9 Jun 2017 11:51:12 +0200 Greg Kroah-Hartman gregkh@linuxfoundation.org wrote: ... >I get the following build error with this patch: > >ERROR: "__spi_register_driver" [drivers/fpga/altera-ps-spi.ko] undefined! it is due to enabled COMPILE_TEST and disabled CONFIG_SPI. >So I'll just ignore this whole series, can you fix these issues up and >resend? would "depends on SPI || (COMPILE_TEST && SPI)" in Kconfig be a proper fix for this? Anyone an idea? Thanks, Anatolij
[toc] | [prev] | [next] | [standalone]
| From | stillcompiling@gmail.com |
|---|---|
| Date | 2017-06-10 00:10 +0200 |
| Subject | Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs |
| Message-ID | <tQAgp-78J-11@gated-at.bofh.it> |
| In reply to | #1662406 |
On Friday, June 9, 2017 3:18:40 PM PDT Anatolij Gustschin wrote: > On Fri, 9 Jun 2017 11:51:12 +0200 > Greg Kroah-Hartman gregkh@linuxfoundation.org wrote: > ... > > >I get the following build error with this patch: > > > >ERROR: "__spi_register_driver" [drivers/fpga/altera-ps-spi.ko] undefined! > > it is due to enabled COMPILE_TEST and disabled CONFIG_SPI. > > >So I'll just ignore this whole series, can you fix these issues up and > >resend? > > would "depends on SPI || (COMPILE_TEST && SPI)" in Kconfig be a proper > fix for this? Anyone an idea? > > Thanks, > Anatolij I don't think that ends up being any different than "depends on SPI" But, it is an SPI slave driver driver, after all. COMPILE_TEST is intended to build stuff that can't work due to a lack of hardware support, or lack of crosscompiler. "selects SPI" would work, but is discouraged. I just built successfully on native x86_64 with no problem, by enabling SPI. "depends on SPI" is the right thing here. I'm not sure when || COMPILE_TEST sneaked in there. I'll submit a v13 with that small change. -- ~Joshua A Clayton
[toc] | [prev] | [next] | [standalone]
| From | Alan Tull <atull@kernel.org> |
|---|---|
| Date | 2017-06-10 16:50 +0200 |
| Subject | Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs |
| Message-ID | <tQPS9-8l2-1@gated-at.bofh.it> |
| In reply to | #1662214 |
On Fri, Jun 9, 2017 at 4:51 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Mon, Jun 05, 2017 at 02:07:37PM -0500, Alan Tull wrote: >> From: Joshua Clayton <stillcompiling@gmail.com> >> >> altera-ps-spi loads FPGA firmware over SPI, using the "passive serial" >> interface on Altera Arria 10, Cyclone V or Stratix V FPGAs. >> >> This is one of the simpler ways to set up an FPGA at runtime. >> The signal interface is close to unidirectional SPI with lsb first. >> >> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> >> Signed-off-by: Anatolij Gustschin <agust@denx.de> >> Signed-off-by: Alan Tull <atull@kernel.org> > > I get the following build error with this patch: > > ERROR: "__spi_register_driver" [drivers/fpga/altera-ps-spi.ko] undefined! > > So I'll just ignore this whole series, can you fix these issues up and > resend? Yes, will do. Alan > > thanks, > > greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web