Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1662776

Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs

Show all headers | View raw

On Friday, June 9, 2017 3:18:40 PM PDT Anatolij Gustschin wrote:
> On Fri, 9 Jun 2017 11:51:12 +0200
> Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
> ...
> 
> >I get the following build error with this patch:
> >
> >ERROR: "__spi_register_driver" [drivers/fpga/altera-ps-spi.ko] undefined!
> 
> it is due to enabled COMPILE_TEST and disabled CONFIG_SPI.
> 
> >So I'll just ignore this whole series, can you fix these issues up and
> >resend?
> 
> would "depends on SPI || (COMPILE_TEST && SPI)" in Kconfig be a proper
> fix for this? Anyone an idea?
> 

> Thanks,
> Anatolij
I don't think that ends up being any different than "depends on SPI"
But, it is an SPI slave driver driver, after all.
COMPILE_TEST is intended to build stuff that can't work due to a lack of 
hardware support, or lack of crosscompiler.
"selects SPI" would work, but is discouraged.

I just built successfully on native x86_64 with no problem, by enabling SPI.
"depends on SPI" is the right thing here.
I'm not sure when || COMPILE_TEST sneaked in there.

I'll submit a v13 with that small change.
-- 
~Joshua A Clayton

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera  FPGAs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 12:00 +0200
  Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera  FPGAs Anatolij Gustschin <agust@denx.de> - 2017-06-09 15:20 +0200
    Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs stillcompiling@gmail.com - 2017-06-10 00:10 +0200
  Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs Alan Tull <atull@kernel.org> - 2017-06-10 16:50 +0200

csiph-web