Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1660877 > unrolled thread

Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper Christoph Hellwig <hch@lst.de> - 2017-06-08 09:50 +0200
    Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-08 09:50 +0200

#1660877 — Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper

>  size_t sg_pcopy_to_buffer(struct scatterlist *sgl, unsigned int nents,
>  			  void *buf, size_t buflen, off_t skip);
>  
> +size_t sg_zeroout_area(struct scatterlist *sgl, unsigned int nents,
> +		       size_t buflen, off_t skip);

Maybe sg_zero_buffer to fit with the other functions in the family?

(I'd be happy to fix this up if you're ok and we don't need another
respin otherwise).

> +	while ((offset < buflen) && sg_miter_next(&miter)) {

Nit: no need for the inner braces.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

[toc] | [next] | [standalone]

#1660879

On 06/08/2017 09:41 AM, Christoph Hellwig wrote:
>>  size_t sg_pcopy_to_buffer(struct scatterlist *sgl, unsigned int nents,
>>  			  void *buf, size_t buflen, off_t skip);
>>  
>> +size_t sg_zeroout_area(struct scatterlist *sgl, unsigned int nents,
>> +		       size_t buflen, off_t skip);
> 
> Maybe sg_zero_buffer to fit with the other functions in the family?
> 
> (I'd be happy to fix this up if you're ok and we don't need another
> respin otherwise).

Sounds good.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web