Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper

From	Christoph Hellwig <hch@lst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper
Date	2017-06-08 09:50 +0200
Message-ID	<tQ0mD-1kN-47@gated-at.bofh.it> (permalink)
References	<tPFLb-4SX-9@gated-at.bofh.it> <tPFLb-4SX-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>  size_t sg_pcopy_to_buffer(struct scatterlist *sgl, unsigned int nents,
>  			  void *buf, size_t buflen, off_t skip);
>  
> +size_t sg_zeroout_area(struct scatterlist *sgl, unsigned int nents,
> +		       size_t buflen, off_t skip);

Maybe sg_zero_buffer to fit with the other functions in the family?

(I'd be happy to fix this up if you're ok and we don't need another
respin otherwise).

> +	while ((offset < buflen) && sg_miter_next(&miter)) {

Nit: no need for the inner braces.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper Christoph Hellwig <hch@lst.de> - 2017-06-08 09:50 +0200
  Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-08 09:50 +0200

csiph-web