Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1656824 > unrolled thread

Re: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

Started byGreg KH <gregkh@linuxfoundation.org>
First post2017-06-03 16:10 +0200
Last post2017-06-06 14:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens Greg KH <gregkh@linuxfoundation.org> - 2017-06-03 16:10 +0200
    RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens Laurentiu Tudor <laurentiu.tudor@nxp.com> - 2017-06-06 14:10 +0200

#1656824 — Re: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-06-03 16:10 +0200
SubjectRe: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens
Message-ID<tOhUC-81i-41@gated-at.bofh.it>
On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tudor@nxp.com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> 
> Several macros didn't had macro params enclosed
> in parens. Fix them to avoid precedence issues.
> 
> Found with checkpatch.pl who was issuing this
> message:
>   "Macro argument 'id' may be better as '(id)'
>    to avoid precedence issues"

Why are you line-wrapping at such a small number?  Please use 72 columns
like git asks you to...

thanks,

greg k-h

[toc] | [next] | [standalone]


#1658686

FromLaurentiu Tudor <laurentiu.tudor@nxp.com>
Date2017-06-06 14:10 +0200
Message-ID<tPlt8-aF-11@gated-at.bofh.it>
In reply to#1656824
Hi Greg,

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Saturday, June 03, 2017 11:41 AM
> 
> On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tudor@nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> >
> > Several macros didn't had macro params enclosed in parens. Fix them to
> > avoid precedence issues.
> >
> > Found with checkpatch.pl who was issuing this
> > message:
> >   "Macro argument 'id' may be better as '(id)'
> >    to avoid precedence issues"
> 
> Why are you line-wrapping at such a small number?  Please use 72 columns like
> git asks you to...

I'll rewrap the commit message in the next spin.

---
Thanks & Best Regards, Laurentiu

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web