Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1658686

RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

From Laurentiu Tudor <laurentiu.tudor@nxp.com>
Newsgroups linux.kernel
Subject RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens
Date 2017-06-06 14:10 +0200
Message-ID <tPlt8-aF-11@gated-at.bofh.it> (permalink)
References <tN9Ps-424-13@gated-at.bofh.it> <tOhUC-81i-43@gated-at.bofh.it> <tOhUC-81i-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Greg,

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Saturday, June 03, 2017 11:41 AM
> 
> On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tudor@nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> >
> > Several macros didn't had macro params enclosed in parens. Fix them to
> > avoid precedence issues.
> >
> > Found with checkpatch.pl who was issuing this
> > message:
> >   "Macro argument 'id' may be better as '(id)'
> >    to avoid precedence issues"
> 
> Why are you line-wrapping at such a small number?  Please use 72 columns like
> git asks you to...

I'll rewrap the commit message in the next spin.

---
Thanks & Best Regards, Laurentiu

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens Greg KH <gregkh@linuxfoundation.org> - 2017-06-03 16:10 +0200
  RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens Laurentiu Tudor <laurentiu.tudor@nxp.com> - 2017-06-06 14:10 +0200

csiph-web