Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1655198 > unrolled thread

[PATCH 0/7] dra7: Fixes for MMC devicetree node

Started byKishon Vijay Abraham I <kishon@ti.com>
First post2017-06-01 16:40 +0200
Last post2017-06-06 14:00 +0200
Articles 8 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/7] dra7: Fixes for MMC devicetree node Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-01 16:40 +0200
    [PATCH 5/7] ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2 Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-01 16:40 +0200
    [PATCH 4/7] ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO lines Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-01 16:40 +0200
    Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-02 13:00 +0200
      Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-06 06:20 +0200
        Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-06 12:40 +0200
          Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node Tony Lindgren <tony@atomide.com> - 2017-06-06 13:00 +0200
            Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-06 14:00 +0200

#1655198 — [PATCH 0/7] dra7: Fixes for MMC devicetree node

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-06-01 16:40 +0200
Subject[PATCH 0/7] dra7: Fixes for MMC devicetree node
Message-ID<tNzqy-3Jw-9@gated-at.bofh.it>
There are the set of fixes that were sent initially as part
of [1].

These are mostly fixes w.r.t populating regulators in
mmc dt node. It was working before because the regulators
connecting to the IO lines are always on regulators. This will
break once we add UHS support where voltage has to be changed
dynamically.

Performed enumeration testing on dra72-evm-revc, dra72-evm,
dra7-evm, am572x-evm, am571x-idk and am572x-idk.

This is a preparation series for adding UHS mode support in
the above mentioned platforms.

[1] -> https://lkml.org/lkml/2017/5/19/196

Kishon Vijay Abraham I (5):
  ARM: dts: dra72-evm-common: Correct vmmc-supply for mmc2
  ARM: dts: dra72-evm: Add vmmc_aux supply to mmc1
  ARM: dts: dra72-evm-revc: Add vmmc_aux supply to mmc1
  ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO
    lines
  ARM: dts: dra7: Add "max-frequency" property to MMC dt nodes

Ravikumar Kattekola (1):
  ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2

Sekhar Nori (1):
  ARM: OMAP2+: Add pdata-quirks for MMC/SD on DRA74x EVM

 arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts |  2 +-
 arch/arm/boot/dts/dra7-evm.dts                | 10 ++++++++-
 arch/arm/boot/dts/dra7.dtsi                   |  5 +++++
 arch/arm/boot/dts/dra71-evm.dts               | 14 ++++++++++++
 arch/arm/boot/dts/dra72-evm-common.dtsi       |  2 --
 arch/arm/boot/dts/dra72-evm-revc.dts          | 18 ++++++++++++++++
 arch/arm/boot/dts/dra72-evm.dts               | 18 ++++++++++++++++
 arch/arm/mach-omap2/pdata-quirks.c            | 31 +++++++++++++++++++++++++++
 include/linux/platform_data/hsmmc-omap.h      |  3 +++
 9 files changed, 99 insertions(+), 4 deletions(-)

-- 
2.11.0

[toc] | [next] | [standalone]

#1655199 — [PATCH 5/7] ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-06-01 16:40 +0200
Subject[PATCH 5/7] ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2
Message-ID<tNzqz-3Jw-31@gated-at.bofh.it>
In reply to#1655198
From: Ravikumar Kattekola <rk@ti.com>

On DRA75x EVM, MMC2 vdd/ios are connected to a common supply fixed at 1.8V
not 3.3V

Fixes: 6cf02dbb4b71 ("ARM: dts: dra7-evm: Add mmc2 node for eMMC support")
Signed-off-by: Ravikumar Kattekola <rk@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/boot/dts/dra7-evm.dts | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index 31a9e061ddd0..e5d7e7f5f645 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -25,6 +25,14 @@
 		stdout-path = &uart1;
 	};
 
+	evm_1v8_sw: fixedregulator-evm_1v8 {
+		compatible = "regulator-fixed";
+		regulator-name = "evm_1v8";
+		vin-supply = <&smps9_reg>;
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
 	evm_3v3_sd: fixedregulator-sd {
 		compatible = "regulator-fixed";
 		regulator-name = "evm_3v3_sd";
@@ -451,7 +459,7 @@
 	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc2_pins_default>;
-	vmmc-supply = <&evm_3v3_sw>;
+	vmmc-supply = <&evm_1v8_sw>;
 	bus-width = <8>;
 };
 
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1655200 — [PATCH 4/7] ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO lines

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-06-01 16:40 +0200
Subject[PATCH 4/7] ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO lines
Message-ID<tNzqz-3Jw-33@gated-at.bofh.it>
In reply to#1655198
The dt binding documentation of omap-hsmmc recommends using
"vmmc_aux" for IO supply lines. However
commit 0af28cc92690d8c ("ARM: dts: am57xx-beagle-x15: Add support
for rev B1") added it as "vmmc-aux". Fix it here.

Fixes: commit 0af28cc92690d8c ("ARM: dts: am57xx-beagle-x15: Add
support for rev B1")

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts b/arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts
index 39a92aff0a0d..6ae94ab52b7b 100644
--- a/arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts
+++ b/arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts
@@ -20,7 +20,7 @@
 
 &mmc1 {
 	vmmc-supply = <&vdd_3v3>;
-	vmmc-aux-supply = <&ldo1_reg>;
+	vmmc_aux-supply = <&ldo1_reg>;
 };
 
 /* errata i880 "Ethernet RGMII2 Limited to 10/100 Mbps" */
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1656131

FromUlf Hansson <ulf.hansson@linaro.org>
Date2017-06-02 13:00 +0200
Message-ID<tNStb-8qp-7@gated-at.bofh.it>
In reply to#1655198
On 1 June 2017 at 16:33, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> There are the set of fixes that were sent initially as part
> of [1].
>
> These are mostly fixes w.r.t populating regulators in
> mmc dt node. It was working before because the regulators
> connecting to the IO lines are always on regulators. This will
> break once we add UHS support where voltage has to be changed
> dynamically.
>
> Performed enumeration testing on dra72-evm-revc, dra72-evm,
> dra7-evm, am572x-evm, am571x-idk and am572x-idk.
>
> This is a preparation series for adding UHS mode support in
> the above mentioned platforms.
>
> [1] -> https://lkml.org/lkml/2017/5/19/196
>
> Kishon Vijay Abraham I (5):
>   ARM: dts: dra72-evm-common: Correct vmmc-supply for mmc2
>   ARM: dts: dra72-evm: Add vmmc_aux supply to mmc1
>   ARM: dts: dra72-evm-revc: Add vmmc_aux supply to mmc1
>   ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO
>     lines
>   ARM: dts: dra7: Add "max-frequency" property to MMC dt nodes
>
> Ravikumar Kattekola (1):
>   ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2
>
> Sekhar Nori (1):
>   ARM: OMAP2+: Add pdata-quirks for MMC/SD on DRA74x EVM
>
>  arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts |  2 +-
>  arch/arm/boot/dts/dra7-evm.dts                | 10 ++++++++-
>  arch/arm/boot/dts/dra7.dtsi                   |  5 +++++
>  arch/arm/boot/dts/dra71-evm.dts               | 14 ++++++++++++
>  arch/arm/boot/dts/dra72-evm-common.dtsi       |  2 --
>  arch/arm/boot/dts/dra72-evm-revc.dts          | 18 ++++++++++++++++
>  arch/arm/boot/dts/dra72-evm.dts               | 18 ++++++++++++++++
>  arch/arm/mach-omap2/pdata-quirks.c            | 31 +++++++++++++++++++++++++++
>  include/linux/platform_data/hsmmc-omap.h      |  3 +++
>  9 files changed, 99 insertions(+), 4 deletions(-)

This series add a bunch of new vmmc_aux regulators for the mmc
controller nodes. I would rather see that omap_hsmmc also converts to
use the generic mmc binding for this regulator, which is "vqmmc".

To accomplish that, omap_hsmmc needs to convert to use
mmc_regulator_get_supply(). If the "vqmmc" regulator isn't found, it
should fallback to try the "vmmc_aux".

Can you do that?

Kind regards
Uffe

[toc] | [prev] | [next] | [standalone]

#1658335

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-06-06 06:20 +0200
Message-ID<tPe8h-3Oa-1@gated-at.bofh.it>
In reply to#1656131
Hi,

On Friday 02 June 2017 04:20 PM, Ulf Hansson wrote:
> On 1 June 2017 at 16:33, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> There are the set of fixes that were sent initially as part
>> of [1].
>>
>> These are mostly fixes w.r.t populating regulators in
>> mmc dt node. It was working before because the regulators
>> connecting to the IO lines are always on regulators. This will
>> break once we add UHS support where voltage has to be changed
>> dynamically.
>>
>> Performed enumeration testing on dra72-evm-revc, dra72-evm,
>> dra7-evm, am572x-evm, am571x-idk and am572x-idk.
>>
>> This is a preparation series for adding UHS mode support in
>> the above mentioned platforms.
>>
>> [1] -> https://lkml.org/lkml/2017/5/19/196
>>
>> Kishon Vijay Abraham I (5):
>>   ARM: dts: dra72-evm-common: Correct vmmc-supply for mmc2
>>   ARM: dts: dra72-evm: Add vmmc_aux supply to mmc1
>>   ARM: dts: dra72-evm-revc: Add vmmc_aux supply to mmc1
>>   ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO
>>     lines
>>   ARM: dts: dra7: Add "max-frequency" property to MMC dt nodes
>>
>> Ravikumar Kattekola (1):
>>   ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2
>>
>> Sekhar Nori (1):
>>   ARM: OMAP2+: Add pdata-quirks for MMC/SD on DRA74x EVM
>>
>>  arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts |  2 +-
>>  arch/arm/boot/dts/dra7-evm.dts                | 10 ++++++++-
>>  arch/arm/boot/dts/dra7.dtsi                   |  5 +++++
>>  arch/arm/boot/dts/dra71-evm.dts               | 14 ++++++++++++
>>  arch/arm/boot/dts/dra72-evm-common.dtsi       |  2 --
>>  arch/arm/boot/dts/dra72-evm-revc.dts          | 18 ++++++++++++++++
>>  arch/arm/boot/dts/dra72-evm.dts               | 18 ++++++++++++++++
>>  arch/arm/mach-omap2/pdata-quirks.c            | 31 +++++++++++++++++++++++++++
>>  include/linux/platform_data/hsmmc-omap.h      |  3 +++
>>  9 files changed, 99 insertions(+), 4 deletions(-)
> 
> This series add a bunch of new vmmc_aux regulators for the mmc
> controller nodes. I would rather see that omap_hsmmc also converts to
> use the generic mmc binding for this regulator, which is "vqmmc".
> 
> To accomplish that, omap_hsmmc needs to convert to use
> mmc_regulator_get_supply(). If the "vqmmc" regulator isn't found, it
> should fallback to try the "vmmc_aux".
> 
> Can you do that?

sure, I'll prepare that change.

Thanks
Kishon

[toc] | [prev] | [next] | [standalone]

#1658593

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-06-06 12:40 +0200
Message-ID<tPk41-7uB-1@gated-at.bofh.it>
In reply to#1658335
Hi Tony,

On Tuesday 06 June 2017 09:47 AM, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Friday 02 June 2017 04:20 PM, Ulf Hansson wrote:
>> On 1 June 2017 at 16:33, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>>> There are the set of fixes that were sent initially as part
>>> of [1].
>>>
>>> These are mostly fixes w.r.t populating regulators in
>>> mmc dt node. It was working before because the regulators
>>> connecting to the IO lines are always on regulators. This will
>>> break once we add UHS support where voltage has to be changed
>>> dynamically.
>>>
>>> Performed enumeration testing on dra72-evm-revc, dra72-evm,
>>> dra7-evm, am572x-evm, am571x-idk and am572x-idk.
>>>
>>> This is a preparation series for adding UHS mode support in
>>> the above mentioned platforms.
>>>
>>> [1] -> https://lkml.org/lkml/2017/5/19/196
>>>
>>> Kishon Vijay Abraham I (5):
>>>   ARM: dts: dra72-evm-common: Correct vmmc-supply for mmc2
>>>   ARM: dts: dra72-evm: Add vmmc_aux supply to mmc1
>>>   ARM: dts: dra72-evm-revc: Add vmmc_aux supply to mmc1
>>>   ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO
>>>     lines
>>>   ARM: dts: dra7: Add "max-frequency" property to MMC dt nodes
>>>
>>> Ravikumar Kattekola (1):
>>>   ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2
>>>
>>> Sekhar Nori (1):
>>>   ARM: OMAP2+: Add pdata-quirks for MMC/SD on DRA74x EVM
>>>
>>>  arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts |  2 +-
>>>  arch/arm/boot/dts/dra7-evm.dts                | 10 ++++++++-
>>>  arch/arm/boot/dts/dra7.dtsi                   |  5 +++++
>>>  arch/arm/boot/dts/dra71-evm.dts               | 14 ++++++++++++
>>>  arch/arm/boot/dts/dra72-evm-common.dtsi       |  2 --
>>>  arch/arm/boot/dts/dra72-evm-revc.dts          | 18 ++++++++++++++++
>>>  arch/arm/boot/dts/dra72-evm.dts               | 18 ++++++++++++++++
>>>  arch/arm/mach-omap2/pdata-quirks.c            | 31 +++++++++++++++++++++++++++
>>>  include/linux/platform_data/hsmmc-omap.h      |  3 +++
>>>  9 files changed, 99 insertions(+), 4 deletions(-)
>>
>> This series add a bunch of new vmmc_aux regulators for the mmc
>> controller nodes. I would rather see that omap_hsmmc also converts to
>> use the generic mmc binding for this regulator, which is "vqmmc".
>>
>> To accomplish that, omap_hsmmc needs to convert to use
>> mmc_regulator_get_supply(). If the "vqmmc" regulator isn't found, it
>> should fallback to try the "vmmc_aux".
>>
>> Can you do that?
> 
> sure, I'll prepare that change.

omap3-overo-base.dtsi has the following dt node for mmc.
/* optional on board WiFi */
&mmc2 {
        pinctrl-names = "default";
        pinctrl-0 = <&mmc2_pins>;
        vmmc-supply = <&w3cbw003c_npoweron>;
        vqmmc-supply = <&w3cbw003c_bt_nreset>;
        vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
        bus-width = <4>;
        cap-sdio-irq;
        non-removable;
};

It has both "vqmmc-supply" and "vmmc_aux-supply". However omap-hsmmc driver has
never parsed vqmmc so far. So I'd assume bt was never functional and it's used
only for wifi.

So for the change suggested by Ulf, Can I do something like below, so that we
can keep wifi functional (ignoring bt since that was never functional)?
-       vqmmc-supply = <&w3cbw003c_bt_nreset>;
-       vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
+       vqmmc-supply = <&w3cbw003c_wifi_nreset>;

Thanks
Kishon

[toc] | [prev] | [next] | [standalone]

#1658619

FromTony Lindgren <tony@atomide.com>
Date2017-06-06 13:00 +0200
Message-ID<tPknp-7Bq-39@gated-at.bofh.it>
In reply to#1658593
* Kishon Vijay Abraham I <kishon@ti.com> [170606 03:40]:
> omap3-overo-base.dtsi has the following dt node for mmc.
> /* optional on board WiFi */
> &mmc2 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc2_pins>;
>         vmmc-supply = <&w3cbw003c_npoweron>;
>         vqmmc-supply = <&w3cbw003c_bt_nreset>;
>         vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
>         bus-width = <4>;
>         cap-sdio-irq;
>         non-removable;
> };
> 
> It has both "vqmmc-supply" and "vmmc_aux-supply". However omap-hsmmc driver has
> never parsed vqmmc so far. So I'd assume bt was never functional and it's used
> only for wifi.

Hmm yeah the vqmmc-supply probably got copied from some
other SoC for w3cbw003c.

> So for the change suggested by Ulf, Can I do something like below, so that we
> can keep wifi functional (ignoring bt since that was never functional)?
> -       vqmmc-supply = <&w3cbw003c_bt_nreset>;
> -       vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
> +       vqmmc-supply = <&w3cbw003c_wifi_nreset>;

Optional sdio pins 4 - 8 need separate power and that's
why we have the vmmc_aux supply to start with. But here
there are only four pins, so my guess is that only one
regulator is needed and the the other two are gpio pins
for wland and bt that nowadays should be handled by the
mmc power sequence driver.

Regards,

Tony

[toc] | [prev] | [next] | [standalone]

#1658679

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-06-06 14:00 +0200
Message-ID<tPljs-8jR-1@gated-at.bofh.it>
In reply to#1658619
Hi,

On Tuesday 06 June 2017 04:21 PM, Tony Lindgren wrote:
> * Kishon Vijay Abraham I <kishon@ti.com> [170606 03:40]:
>> omap3-overo-base.dtsi has the following dt node for mmc.
>> /* optional on board WiFi */
>> &mmc2 {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&mmc2_pins>;
>>         vmmc-supply = <&w3cbw003c_npoweron>;
>>         vqmmc-supply = <&w3cbw003c_bt_nreset>;
>>         vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
>>         bus-width = <4>;
>>         cap-sdio-irq;
>>         non-removable;
>> };
>>
>> It has both "vqmmc-supply" and "vmmc_aux-supply". However omap-hsmmc driver has
>> never parsed vqmmc so far. So I'd assume bt was never functional and it's used
>> only for wifi.
> 
> Hmm yeah the vqmmc-supply probably got copied from some
> other SoC for w3cbw003c.

Okay. So I think we can remove vqmmc-supply here without breaking any existing
functionality.
> 
>> So for the change suggested by Ulf, Can I do something like below, so that we
>> can keep wifi functional (ignoring bt since that was never functional)?
>> -       vqmmc-supply = <&w3cbw003c_bt_nreset>;
>> -       vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
>> +       vqmmc-supply = <&w3cbw003c_wifi_nreset>;
> 
> Optional sdio pins 4 - 8 need separate power and that's
> why we have the vmmc_aux supply to start with. But here
> there are only four pins, so my guess is that only one
> regulator is needed and the the other two are gpio pins
> for wland and bt that nowadays should be handled by the
> mmc power sequence driver.

Yeah. Just now checked the pwrseq driver (pwrseq_simple), but it has it's own
binding. So even if we move to the pwrseq, we still have to support
"vqmmc-supply = <&w3cbw003c_wifi_nreset>" to avoid breaking old dt compatibiltiy.

Thanks
Kishon

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web