Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node
Date	2017-06-06 13:00 +0200
Message-ID	<tPknp-7Bq-39@gated-at.bofh.it> (permalink)
References	<tNzqy-3Jw-9@gated-at.bofh.it> <tNStb-8qp-7@gated-at.bofh.it> <tPe8h-3Oa-1@gated-at.bofh.it> <tPk41-7uB-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Kishon Vijay Abraham I <kishon@ti.com> [170606 03:40]:
> omap3-overo-base.dtsi has the following dt node for mmc.
> /* optional on board WiFi */
> &mmc2 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc2_pins>;
>         vmmc-supply = <&w3cbw003c_npoweron>;
>         vqmmc-supply = <&w3cbw003c_bt_nreset>;
>         vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
>         bus-width = <4>;
>         cap-sdio-irq;
>         non-removable;
> };
> 
> It has both "vqmmc-supply" and "vmmc_aux-supply". However omap-hsmmc driver has
> never parsed vqmmc so far. So I'd assume bt was never functional and it's used
> only for wifi.

Hmm yeah the vqmmc-supply probably got copied from some
other SoC for w3cbw003c.

> So for the change suggested by Ulf, Can I do something like below, so that we
> can keep wifi functional (ignoring bt since that was never functional)?
> -       vqmmc-supply = <&w3cbw003c_bt_nreset>;
> -       vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
> +       vqmmc-supply = <&w3cbw003c_wifi_nreset>;

Optional sdio pins 4 - 8 need separate power and that's
why we have the vmmc_aux supply to start with. But here
there are only four pins, so my guess is that only one
regulator is needed and the the other two are gpio pins
for wland and bt that nowadays should be handled by the
mmc power sequence driver.

Regards,

Tony

Thread

[PATCH 0/7] dra7: Fixes for MMC devicetree node Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-01 16:40 +0200
  [PATCH 5/7] ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2 Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-01 16:40 +0200
  [PATCH 4/7] ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO lines Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-01 16:40 +0200
  Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-02 13:00 +0200
    Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-06 06:20 +0200
      Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-06 12:40 +0200
        Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node Tony Lindgren <tony@atomide.com> - 2017-06-06 13:00 +0200
          Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-06 14:00 +0200

csiph-web