Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1660665 > unrolled thread

Re: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-08 04:20 +0200
    RE: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver "Keiji Hayashibara" <hayashibara.keiji@socionext.com> - 2017-06-08 08:00 +0200

#1660665 — Re: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver

Hayashibara-san

Just a nit.


> +
> +#include <linux/module.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +#include <linux/watchdog.h>
> +#include <linux/bitops.h>

I think you should have added <linux/bitops.h> on the top
to keep the includes alphabetically sorted.


-- 
Best Regards
Masahiro Yamada

[toc] | [next] | [standalone]

#1660767

Hello Yamada-san,

> > +
> > +#include <linux/module.h>
> > +#include <linux/mfd/syscon.h>
> > +#include <linux/of.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/regmap.h>
> > +#include <linux/watchdog.h>
> > +#include <linux/bitops.h>
> 
> I think you should have added <linux/bitops.h> on the top
> to keep the includes alphabetically sorted.

Sorry, I will fix in v3 patch.

----------
Best Regards,
Keiji Hayashibara

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web