RE: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver

From	"Keiji Hayashibara" <hayashibara.keiji@socionext.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver
Date	2017-06-08 08:00 +0200
Message-ID	<tPYEa-d6-9@gated-at.bofh.it> (permalink)
References	<tPiOD-6Mu-13@gated-at.bofh.it> <tPiOD-6Mu-25@gated-at.bofh.it> <tPVdg-6yC-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Yamada-san,

> > +
> > +#include <linux/module.h>
> > +#include <linux/mfd/syscon.h>
> > +#include <linux/of.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/regmap.h>
> > +#include <linux/watchdog.h>
> > +#include <linux/bitops.h>
> 
> I think you should have added <linux/bitops.h> on the top
> to keep the includes alphabetically sorted.

Sorry, I will fix in v3 patch.

----------
Best Regards,
Keiji Hayashibara

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-08 04:20 +0200
  RE: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver "Keiji Hayashibara" <hayashibara.keiji@socionext.com> - 2017-06-08 08:00 +0200

csiph-web