Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1656614 > unrolled thread
| Started by | srishti sharma <srishtishar@gmail.com> |
|---|---|
| First post | 2017-06-03 00:50 +0200 |
| Last post | 2017-06-03 20:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error. srishti sharma <srishtishar@gmail.com> - 2017-06-03 00:50 +0200
Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error. Greg KH <gregkh@linuxfoundation.org> - 2017-06-03 16:10 +0200
Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error. srishti sharma <srishtishar@gmail.com> - 2017-06-03 20:00 +0200
| From | srishti sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-06-03 00:50 +0200 |
| Subject | [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error. |
| Message-ID | <tO3yi-7c0-1@gated-at.bofh.it> |
Fixed a pointer declaration error , the dereferencing operator was misplaced.
Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
drivers/staging/ccree/ssi_aead.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.h b/drivers/staging/ccree/ssi_aead.h
index 654a181..9cf5225 100644
--- a/drivers/staging/ccree/ssi_aead.h
+++ b/drivers/staging/ccree/ssi_aead.h
@@ -97,8 +97,8 @@ struct aead_req_ctx {
struct ssi_mlli assoc;
struct ssi_mlli src;
struct ssi_mlli dst;
- struct scatterlist* srcSgl;
- struct scatterlist* dstSgl;
+ struct scatterlist *srcSgl;
+ struct scatterlist *dstSgl;
unsigned int srcOffset;
unsigned int dstOffset;
enum ssi_req_dma_buf_type assoc_buff_type;
--
2.7.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-06-03 16:10 +0200 |
| Subject | Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error. |
| Message-ID | <tOhUB-81i-1@gated-at.bofh.it> |
| In reply to | #1656614 |
On Sat, Jun 03, 2017 at 04:15:17AM +0530, srishti sharma wrote: > Fixed a pointer declaration error , the dereferencing operator was misplaced. Odd use of a , Also, I don't understand what was "misplaced" here? There does not seem to be a "error" fixed here...
[toc] | [prev] | [next] | [standalone]
| From | srishti sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-06-03 20:00 +0200 |
| Message-ID | <tOlvc-1CJ-13@gated-at.bofh.it> |
| In reply to | #1656808 |
Hey, checkpatch.pl generated two errors , because the dereferencing operator was placed next to the structure name instead of being placed with the pointer . for eg: struct scatterlist* srcSgl; (this was giving an error) whereas struct scatterlist *srcSgl; (this did not give an error) Both of them will compile , but the second one is a better representation of it and does not produce an error on running checkpatch.pl . Regards, Srishti On Sat, Jun 3, 2017 at 2:07 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Sat, Jun 03, 2017 at 04:15:17AM +0530, srishti sharma wrote: >> Fixed a pointer declaration error , the dereferencing operator was misplaced. > > Odd use of a , > > Also, I don't understand what was "misplaced" here? There does not seem > to be a "error" fixed here... >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web