Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.

From	srishti sharma <srishtishar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.
Date	2017-06-03 20:00 +0200
Message-ID	<tOlvc-1CJ-13@gated-at.bofh.it> (permalink)
References	<tO3yi-7c0-1@gated-at.bofh.it> <tOhUB-81i-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hey,

checkpatch.pl generated two errors , because the dereferencing
operator was placed next to the structure name instead of being placed
with the pointer .

for eg:
  struct scatterlist* srcSgl; (this was giving an error)

whereas
 struct scatterlist *srcSgl; (this did not give an error)

Both of them will compile , but the second one is a better
representation of it and does not produce an error on running
checkpatch.pl .

Regards,
Srishti

On Sat, Jun 3, 2017 at 2:07 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Jun 03, 2017 at 04:15:17AM +0530, srishti sharma wrote:
>> Fixed a pointer declaration error , the dereferencing operator was misplaced.
>
> Odd use of a ,
>
> Also, I don't understand what was "misplaced" here?  There does not seem
> to be a "error" fixed here...
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error. srishti sharma <srishtishar@gmail.com> - 2017-06-03 00:50 +0200
  Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration  error. Greg KH <gregkh@linuxfoundation.org> - 2017-06-03 16:10 +0200
    Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error. srishti sharma <srishtishar@gmail.com> - 2017-06-03 20:00 +0200

csiph-web