Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1656529 > unrolled thread
| Started by | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| First post | 2017-06-02 22:40 +0200 |
| Last post | 2017-06-02 23:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox Wolfram Sang <wsa@the-dreams.de> - 2017-06-02 22:40 +0200
Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox Loc Ho <lho@apm.com> - 2017-06-02 22:40 +0200
Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox Hoan Tran <hotran@apm.com> - 2017-06-02 23:00 +0200
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-06-02 22:40 +0200 |
| Subject | Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox |
| Message-ID | <tO1wt-5YJ-7@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Mon, Apr 24, 2017 at 11:00:26AM -0700, Hoan Tran wrote:
> This patch adds ACPI support by using PCC mailbox communication
> interface.
>
> Signed-off-by: Hoan Tran <hotran@apm.com>
Please make use checkpatch:
WARNING: braces {} are not necessary for single statement blocks
#149: FILE: drivers/i2c/busses/i2c-xgene-slimpro.c:242:
+ if (!acpi_disabled) {
+ mbox_chan_txdone(ctx->mbox_chan, 0);
+ }
Fixed that and applied to for-next, thanks!
BTW is there anyone inside apm.com who is willing to take over maintainership
for this driver? This person needs to review patches thoroughly, yet it usually
means patches will go in faster.
Regards,
Wolfram
[toc] | [next] | [standalone]
| From | Loc Ho <lho@apm.com> |
|---|---|
| Date | 2017-06-02 22:40 +0200 |
| Subject | Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox |
| Message-ID | <tO1wt-5YJ-11@gated-at.bofh.it> |
| In reply to | #1656529 |
Hi Wolfram,
>> This patch adds ACPI support by using PCC mailbox communication
>> interface.
>>
>> Signed-off-by: Hoan Tran <hotran@apm.com>
>
> Please make use checkpatch:
>
> WARNING: braces {} are not necessary for single statement blocks
> #149: FILE: drivers/i2c/busses/i2c-xgene-slimpro.c:242:
> + if (!acpi_disabled) {
> + mbox_chan_txdone(ctx->mbox_chan, 0);
> + }
>
> Fixed that and applied to for-next, thanks!
>
> BTW is there anyone inside apm.com who is willing to take over maintainership
> for this driver? This person needs to review patches thoroughly, yet it usually
> means patches will go in faster.
Thanks for fixing the warning message. Given that Duc has left MACOM
(previously APM), we are ramping up another person.
Thanks,
Loc
[toc] | [prev] | [next] | [standalone]
| From | Hoan Tran <hotran@apm.com> |
|---|---|
| Date | 2017-06-02 23:00 +0200 |
| Subject | Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox |
| Message-ID | <tO1PP-65t-7@gated-at.bofh.it> |
| In reply to | #1656529 |
On Fri, Jun 2, 2017 at 1:31 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Mon, Apr 24, 2017 at 11:00:26AM -0700, Hoan Tran wrote:
>> This patch adds ACPI support by using PCC mailbox communication
>> interface.
>>
>> Signed-off-by: Hoan Tran <hotran@apm.com>
>
> Please make use checkpatch:
>
> WARNING: braces {} are not necessary for single statement blocks
> #149: FILE: drivers/i2c/busses/i2c-xgene-slimpro.c:242:
> + if (!acpi_disabled) {
> + mbox_chan_txdone(ctx->mbox_chan, 0);
> + }
>
> Fixed that and applied to for-next, thanks!
Thanks, Wolfram!
Regards,
Hoan
>
> BTW is there anyone inside apm.com who is willing to take over maintainership
> for this driver? This person needs to review patches thoroughly, yet it usually
> means patches will go in faster.
>
> Regards,
>
> Wolfram
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web