Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1656530

Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

From Loc Ho <lho@apm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox
Date 2017-06-02 22:40 +0200
Message-ID <tO1wt-5YJ-11@gated-at.bofh.it> (permalink)
References <tzQAW-1Uk-7@gated-at.bofh.it> <tzQAW-1Uk-5@gated-at.bofh.it> <tO1wt-5YJ-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Wolfram,

>> This patch adds ACPI support by using PCC mailbox communication
>> interface.
>>
>> Signed-off-by: Hoan Tran <hotran@apm.com>
>
> Please make use checkpatch:
>
> WARNING: braces {} are not necessary for single statement blocks
> #149: FILE: drivers/i2c/busses/i2c-xgene-slimpro.c:242:
> +       if (!acpi_disabled) {
> +               mbox_chan_txdone(ctx->mbox_chan, 0);
> +       }
>
> Fixed that and applied to for-next, thanks!
>
> BTW is there anyone inside apm.com who is willing to take over maintainership
> for this driver? This person needs to review patches thoroughly, yet it usually
> means patches will go in faster.

Thanks for fixing the warning message. Given that Duc has left MACOM
(previously APM), we are ramping up another person.

Thanks,
Loc

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC  mailbox Wolfram Sang <wsa@the-dreams.de> - 2017-06-02 22:40 +0200
  Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox Loc Ho <lho@apm.com> - 2017-06-02 22:40 +0200
  Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox Hoan Tran <hotran@apm.com> - 2017-06-02 23:00 +0200

csiph-web