Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1654688 > unrolled thread
| Started by | Andrea Adami <andrea.adami@gmail.com> |
|---|---|
| First post | 2017-06-01 00:50 +0200 |
| Last post | 2017-06-01 10:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3 5/9] mtd: nand: tmio_nand.c: take in account partition parser types Andrea Adami <andrea.adami@gmail.com> - 2017-06-01 00:50 +0200
Re: [PATCH v3 5/9] mtd: nand: tmio_nand.c: take in account partition parser types Wolfram Sang <wsa@the-dreams.de> - 2017-06-01 10:40 +0200
| From | Andrea Adami <andrea.adami@gmail.com> |
|---|---|
| Date | 2017-06-01 00:50 +0200 |
| Subject | [PATCH v3 5/9] mtd: nand: tmio_nand.c: take in account partition parser types |
| Message-ID | <tNkBb-2ET-1@gated-at.bofh.it> |
Signed-off-by: Andrea Adami <andrea.adami@gmail.com> --- drivers/mtd/nand/tmio_nand.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/tmio_nand.c b/drivers/mtd/nand/tmio_nand.c index fc5e773..bea05bb 100644 --- a/drivers/mtd/nand/tmio_nand.c +++ b/drivers/mtd/nand/tmio_nand.c @@ -440,7 +440,9 @@ static int tmio_probe(struct platform_device *dev) goto err_irq; /* Register the partitions */ - retval = mtd_device_parse_register(mtd, NULL, NULL, + retval = mtd_device_parse_register(mtd, + data->types ? data->types : NULL, + NULL, data ? data->partition : NULL, data ? data->num_partitions : 0); if (!retval) -- 2.7.4
[toc] | [next] | [standalone]
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-06-01 10:40 +0200 |
| Subject | Re: [PATCH v3 5/9] mtd: nand: tmio_nand.c: take in account partition parser types |
| Message-ID | <tNtO9-cj-9@gated-at.bofh.it> |
| In reply to | #1654688 |
[Multipart message — attachments visible in raw view] — view raw
> - retval = mtd_device_parse_register(mtd, NULL, NULL, > + retval = mtd_device_parse_register(mtd, > + data->types ? data->types : NULL, This is superfluous. You want to check against 'data' instead as it is done below. Otherwis you might get a NULL pointer dereference. > + NULL, > data ? data->partition : NULL, > data ? data->num_partitions : 0);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web