Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1654927

Re: [PATCH v3 5/9] mtd: nand: tmio_nand.c: take in account partition parser types

From Wolfram Sang <wsa@the-dreams.de>
Newsgroups linux.kernel
Subject Re: [PATCH v3 5/9] mtd: nand: tmio_nand.c: take in account partition parser types
Date 2017-06-01 10:40 +0200
Message-ID <tNtO9-cj-9@gated-at.bofh.it> (permalink)
References <tNkBb-2ET-3@gated-at.bofh.it> <tNkBb-2ET-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

> -	retval = mtd_device_parse_register(mtd, NULL, NULL,
> +	retval = mtd_device_parse_register(mtd,
> +					   data->types ? data->types : NULL,

This is superfluous. You want to check against 'data' instead as it is
done below. Otherwis you might get a NULL pointer dereference.

> +					   NULL,
>  					   data ? data->partition : NULL,
>  					   data ? data->num_partitions : 0);

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v3 5/9] mtd: nand: tmio_nand.c: take in account partition parser types Andrea Adami <andrea.adami@gmail.com> - 2017-06-01 00:50 +0200
  Re: [PATCH v3 5/9] mtd: nand: tmio_nand.c: take in account partition  parser types Wolfram Sang <wsa@the-dreams.de> - 2017-06-01 10:40 +0200

csiph-web