Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1656268 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-02 16:20 +0200 |
| Last post | 2017-06-05 02:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH][V2] net: phy: marvell: make some functions static Colin King <colin.king@canonical.com> - 2017-06-02 16:20 +0200
Re: [PATCH][V2] net: phy: marvell: make some functions static Florian Fainelli <f.fainelli@gmail.com> - 2017-06-02 18:50 +0200
Re: [PATCH][V2] net: phy: marvell: make some functions static David Miller <davem@davemloft.net> - 2017-06-05 02:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-02 16:20 +0200 |
| Subject | [PATCH][V2] net: phy: marvell: make some functions static |
| Message-ID | <tNVAK-2ht-9@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
functions m88e1510_get_temp_critical, m88e1510_set_temp_critical and
m88e1510_get_temp_alarm can be made static as they not need to be
in global scope.
Cleans up sparse warnings:
"symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?"
"symbol 'm88e1510_get_temp_critical' was not declared. Should it be
static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/phy/marvell.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 7c2cde45c262..7382b8fc77e2 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -1704,7 +1704,7 @@ static int m88e1510_get_temp(struct phy_device *phydev, long *temp)
return ret;
}
-int m88e1510_get_temp_critical(struct phy_device *phydev, long *temp)
+static int m88e1510_get_temp_critical(struct phy_device *phydev, long *temp)
{
int oldpage;
int ret;
@@ -1735,7 +1735,7 @@ int m88e1510_get_temp_critical(struct phy_device *phydev, long *temp)
return ret;
}
-int m88e1510_set_temp_critical(struct phy_device *phydev, long temp)
+static int m88e1510_set_temp_critical(struct phy_device *phydev, long temp)
{
int oldpage;
int ret;
@@ -1765,7 +1765,7 @@ int m88e1510_set_temp_critical(struct phy_device *phydev, long temp)
return ret;
}
-int m88e1510_get_temp_alarm(struct phy_device *phydev, long *alarm)
+static int m88e1510_get_temp_alarm(struct phy_device *phydev, long *alarm)
{
int oldpage;
int ret;
--
2.11.0
[toc] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-06-02 18:50 +0200 |
| Message-ID | <tNXVT-3GU-11@gated-at.bofh.it> |
| In reply to | #1656268 |
On 06/02/2017 07:13 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > functions m88e1510_get_temp_critical, m88e1510_set_temp_critical and > m88e1510_get_temp_alarm can be made static as they not need to be > in global scope. > > Cleans up sparse warnings: > "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?" > "symbol 'm88e1510_get_temp_critical' was not declared. Should it be > static?" > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-06-05 02:00 +0200 |
| Message-ID | <tONB7-3oN-9@gated-at.bofh.it> |
| In reply to | #1656268 |
From: Colin King <colin.king@canonical.com> Date: Fri, 2 Jun 2017 15:13:34 +0100 > From: Colin Ian King <colin.king@canonical.com> > > functions m88e1510_get_temp_critical, m88e1510_set_temp_critical and > m88e1510_get_temp_alarm can be made static as they not need to be > in global scope. > > Cleans up sparse warnings: > "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?" > "symbol 'm88e1510_get_temp_critical' was not declared. Should it be > static?" > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to net-next, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web