Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1656393

Re: [PATCH][V2] net: phy: marvell: make some functions static

Show all headers | View raw

On 06/02/2017 07:13 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> functions m88e1510_get_temp_critical, m88e1510_set_temp_critical and
> m88e1510_get_temp_alarm can be made static as they not need to be
> in global scope.
> 
> Cleans up sparse warnings:
>  "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?"
>  "symbol 'm88e1510_get_temp_critical' was not declared. Should it be
>   static?"
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH][V2] net: phy: marvell: make some functions static Colin King <colin.king@canonical.com> - 2017-06-02 16:20 +0200
  Re: [PATCH][V2] net: phy: marvell: make some functions static Florian Fainelli <f.fainelli@gmail.com> - 2017-06-02 18:50 +0200
  Re: [PATCH][V2] net: phy: marvell: make some functions static David Miller <davem@davemloft.net> - 2017-06-05 02:00 +0200

csiph-web