Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1656341 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-02 17:30 +0200 |
| Last post | 2017-06-05 02:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH][net-next] rxrpc: remove redundant proc_remove call Colin King <colin.king@canonical.com> - 2017-06-02 17:30 +0200
Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call David Howells <dhowells@redhat.com> - 2017-06-02 23:40 +0200
Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call David Miller <davem@davemloft.net> - 2017-06-05 02:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-02 17:30 +0200 |
| Subject | [PATCH][net-next] rxrpc: remove redundant proc_remove call |
| Message-ID | <tNWGv-2XT-33@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The proc_remove call is dead code as it occurs after a return and
hence can never be called. Remove it.
Detected by CoverityScan, CID#1437743 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/rxrpc/net_ns.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/rxrpc/net_ns.c b/net/rxrpc/net_ns.c
index 26449a6bb076..7edceb8522f5 100644
--- a/net/rxrpc/net_ns.c
+++ b/net/rxrpc/net_ns.c
@@ -59,7 +59,6 @@ static __net_init int rxrpc_init_net(struct net *net)
proc_create("conns", 0444, rxnet->proc_net, &rxrpc_connection_seq_fops);
return 0;
- proc_remove(rxnet->proc_net);
err_proc:
return ret;
}
--
2.11.0
[toc] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2017-06-02 23:40 +0200 |
| Message-ID | <tO2sx-6xE-3@gated-at.bofh.it> |
| In reply to | #1656341 |
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The proc_remove call is dead code as it occurs after a return and
> hence can never be called. Remove it.
>
> Detected by CoverityScan, CID#1437743 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: David Howells <dhowells@redhat.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-06-05 02:00 +0200 |
| Message-ID | <tONB7-3oN-5@gated-at.bofh.it> |
| In reply to | #1656341 |
From: Colin King <colin.king@canonical.com>
Date: Fri, 2 Jun 2017 16:22:27 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The proc_remove call is dead code as it occurs after a return and
> hence can never be called. Remove it.
>
> Detected by CoverityScan, CID#1437743 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web