Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1655751 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2017-06-01 22:50 +0200 |
| Last post | 2017-06-07 09:10 +0200 |
| Articles | 6 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/5] ARM-OMAP1: Adjustments for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 22:50 +0200
[PATCH 2/5] ARM: OMAP1: DMA: Delete an error message for a failed memory allocation in omap1_system_dma_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 22:50 +0200
[PATCH 5/5] ARM: OMAP1: Fix a typo in a comment line SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 23:00 +0200
[PATCH 4/5] ARM: OMAP1: Delete an error message for a failed memory allocation in omap1_dm_timer_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 23:00 +0200
[PATCH 3/5] ARM: OMAP1: DMA: Delete an unnecessary return statement in omap1_show_dma_caps() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 23:00 +0200
Re: [PATCH 0/5] ARM-OMAP1: Adjustments for three function implementations Tony Lindgren <tony@atomide.com> - 2017-06-07 09:10 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-06-01 22:50 +0200 |
| Subject | [PATCH 0/5] ARM-OMAP1: Adjustments for three function implementations |
| Message-ID | <tNFcB-7FC-19@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Thu, 1 Jun 2017 22:40:04 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Improve a size determination in omap1_system_dma_init() Delete an error message for a failed memory allocation in omap1_system_dma_init() Delete an unnecessary return statement in omap1_show_dma_caps() Delete an error message for a failed memory allocation in omap1_dm_timer_init() Fix a typo in a comment line arch/arm/mach-omap1/dma.c | 5 +---- arch/arm/mach-omap1/timer.c | 4 +--- 2 files changed, 2 insertions(+), 7 deletions(-) -- 2.13.0
[toc] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-06-01 22:50 +0200 |
| Subject | [PATCH 2/5] ARM: OMAP1: DMA: Delete an error message for a failed memory allocation in omap1_system_dma_init() |
| Message-ID | <tNFcC-7FC-25@gated-at.bofh.it> |
| In reply to | #1655751 |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 1 Jun 2017 21:54:36 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/arm/mach-omap1/dma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-omap1/dma.c b/arch/arm/mach-omap1/dma.c
index 823dba3dc033..c545b4e01d53 100644
--- a/arch/arm/mach-omap1/dma.c
+++ b/arch/arm/mach-omap1/dma.c
@@ -343,6 +343,4 @@ static int __init omap1_system_dma_init(void)
if (!d) {
- dev_err(&pdev->dev, "%s: Unable to allocate 'd' for %s\n",
- __func__, pdev->name);
ret = -ENOMEM;
goto exit_iounmap;
}
--
2.13.0
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-06-01 23:00 +0200 |
| Subject | [PATCH 5/5] ARM: OMAP1: Fix a typo in a comment line |
| Message-ID | <tNFmh-7IJ-1@gated-at.bofh.it> |
| In reply to | #1655751 |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Thu, 1 Jun 2017 22:17:03 +0200 Adjust a line in this description for the software module. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- arch/arm/mach-omap1/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap1/timer.c b/arch/arm/mach-omap1/timer.c index 637f8c9d9f10..8fb1ec6fa999 100644 --- a/arch/arm/mach-omap1/timer.c +++ b/arch/arm/mach-omap1/timer.c @@ -3,7 +3,7 @@ * * Contains first level initialization routines which internally * generates timer device information and registers with linux - * device model. It also has low level function to chnage the timer + * device model. It also has a low level function to change the timer * input clock source. * * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/ -- 2.13.0
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-06-01 23:00 +0200 |
| Subject | [PATCH 4/5] ARM: OMAP1: Delete an error message for a failed memory allocation in omap1_dm_timer_init() |
| Message-ID | <tNFmi-7IJ-11@gated-at.bofh.it> |
| In reply to | #1655751 |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 1 Jun 2017 22:04:29 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/arm/mach-omap1/timer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-omap1/timer.c b/arch/arm/mach-omap1/timer.c
index 06c5ba7574a5..637f8c9d9f10 100644
--- a/arch/arm/mach-omap1/timer.c
+++ b/arch/arm/mach-omap1/timer.c
@@ -136,6 +136,4 @@ static int __init omap1_dm_timer_init(void)
if (!pdata) {
- dev_err(&pdev->dev, "%s: Failed to allocate pdata.\n",
- __func__);
ret = -ENOMEM;
goto err_free_pdata;
}
--
2.13.0
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-06-01 23:00 +0200 |
| Subject | [PATCH 3/5] ARM: OMAP1: DMA: Delete an unnecessary return statement in omap1_show_dma_caps() |
| Message-ID | <tNFmi-7IJ-17@gated-at.bofh.it> |
| In reply to | #1655751 |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Thu, 1 Jun 2017 22:00:21 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected function. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- arch/arm/mach-omap1/dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-omap1/dma.c b/arch/arm/mach-omap1/dma.c index c545b4e01d53..52d7eda1adec 100644 --- a/arch/arm/mach-omap1/dma.c +++ b/arch/arm/mach-omap1/dma.c @@ -240,7 +240,6 @@ static void omap1_show_dma_caps(void) w |= 1 << 3; dma_write(w, GSCR, 0); } - return; } static unsigned configure_dma_errata(void) -- 2.13.0
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-06-07 09:10 +0200 |
| Subject | Re: [PATCH 0/5] ARM-OMAP1: Adjustments for three function implementations |
| Message-ID | <tPDgn-3om-57@gated-at.bofh.it> |
| In reply to | #1655751 |
* SF Markus Elfring <elfring@users.sourceforge.net> [170601 13:50]: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Thu, 1 Jun 2017 22:40:04 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): > Improve a size determination in omap1_system_dma_init() > Delete an error message for a failed memory allocation in omap1_system_dma_init() > Delete an unnecessary return statement in omap1_show_dma_caps() > Delete an error message for a failed memory allocation in omap1_dm_timer_init() > Fix a typo in a comment line > > arch/arm/mach-omap1/dma.c | 5 +---- > arch/arm/mach-omap1/timer.c | 4 +--- > 2 files changed, 2 insertions(+), 7 deletions(-) Thanks applying all into omap-for-v4.13/omap1. Tony
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web