Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1655762

[PATCH 3/5] ARM: OMAP1: DMA: Delete an unnecessary return statement in omap1_show_dma_caps()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 3/5] ARM: OMAP1: DMA: Delete an unnecessary return statement in omap1_show_dma_caps()
Date 2017-06-01 23:00 +0200
Message-ID <tNFmi-7IJ-17@gated-at.bofh.it> (permalink)
References <tNFcB-7FC-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 1 Jun 2017 22:00:21 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/arm/mach-omap1/dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-omap1/dma.c b/arch/arm/mach-omap1/dma.c
index c545b4e01d53..52d7eda1adec 100644
--- a/arch/arm/mach-omap1/dma.c
+++ b/arch/arm/mach-omap1/dma.c
@@ -240,7 +240,6 @@ static void omap1_show_dma_caps(void)
 		w |= 1 << 3;
 		dma_write(w, GSCR, 0);
 	}
-	return;
 }
 
 static unsigned configure_dma_errata(void)
-- 
2.13.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] ARM-OMAP1: Adjustments for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 22:50 +0200
  [PATCH 2/5] ARM: OMAP1: DMA: Delete an error message for a failed  memory allocation in omap1_system_dma_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 22:50 +0200
  [PATCH 5/5] ARM: OMAP1: Fix a typo in a comment line SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 23:00 +0200
  [PATCH 4/5] ARM: OMAP1: Delete an error message for a failed memory  allocation in omap1_dm_timer_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 23:00 +0200
  [PATCH 3/5] ARM: OMAP1: DMA: Delete an unnecessary return statement  in omap1_show_dma_caps() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-06-01 23:00 +0200
  Re: [PATCH 0/5] ARM-OMAP1: Adjustments for three function  implementations Tony Lindgren <tony@atomide.com> - 2017-06-07 09:10 +0200

csiph-web