Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1652509 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-05-29 15:00 +0200 |
| Last post | 2017-05-30 20:10 +0200 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Arnd Bergmann <arnd@arndb.de> - 2017-05-29 15:00 +0200
Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-29 17:10 +0200
Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Andrew Lunn <andrew@lunn.ch> - 2017-05-29 17:40 +0200
Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Arnd Bergmann <arnd@arndb.de> - 2017-05-29 23:10 +0200
Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Andrew Lunn <andrew@lunn.ch> - 2017-05-30 19:00 +0200
Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions David Miller <davem@davemloft.net> - 2017-05-30 20:10 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-05-29 15:00 +0200 |
| Subject | [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions |
| Message-ID | <tMsr8-8qg-25@gated-at.bofh.it> |
'static' was not enough, the helpers must be 'static inline'
net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/dsa/mv88e6xxx/global2.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/global2.h b/drivers/net/dsa/mv88e6xxx/global2.h
index d8d3c5abb2a1..14c0be98e0a4 100644
--- a/drivers/net/dsa/mv88e6xxx/global2.h
+++ b/drivers/net/dsa/mv88e6xxx/global2.h
@@ -114,13 +114,13 @@ static inline int mv88e6xxx_g2_set_eeprom16(struct mv88e6xxx_chip *chip,
return -EOPNOTSUPP;
}
-static int mv88e6xxx_g2_pvt_write(struct mv88e6xxx_chip *chip, int src_dev,
- int src_port, u16 data)
+static inline int mv88e6xxx_g2_pvt_write(struct mv88e6xxx_chip *chip,
+ int src_dev, int src_port, u16 data)
{
return -EOPNOTSUPP;
}
-static int mv88e6xxx_g2_misc_4_bit_port(struct mv88e6xxx_chip *chip)
+static inline int mv88e6xxx_g2_misc_4_bit_port(struct mv88e6xxx_chip *chip)
{
return -EOPNOTSUPP;
}
--
2.9.0
[toc] | [next] | [standalone]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2017-05-29 17:10 +0200 |
| Message-ID | <tMusW-1Cu-13@gated-at.bofh.it> |
| In reply to | #1652509 |
Hi Arnd,
Arnd Bergmann <arnd@arndb.de> writes:
> 'static' was not enough, the helpers must be 'static inline'
>
> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
>
> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Thanks,
Vivien
[toc] | [prev] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2017-05-29 17:40 +0200 |
| Message-ID | <tMuVY-1P8-23@gated-at.bofh.it> |
| In reply to | #1652509 |
On Mon, May 29, 2017 at 02:56:01PM +0200, Arnd Bergmann wrote:
> 'static' was not enough, the helpers must be 'static inline'
>
> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
>
> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd
Dave merged my fix yesterday.
Andrew
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-05-29 23:10 +0200 |
| Message-ID | <tMA5k-5Ez-29@gated-at.bofh.it> |
| In reply to | #1652598 |
On Mon, May 29, 2017 at 5:30 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> On Mon, May 29, 2017 at 02:56:01PM +0200, Arnd Bergmann wrote:
>> 'static' was not enough, the helpers must be 'static inline'
>>
>> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
>> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
>>
>> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Hi Arnd
>
> Dave merged my fix yesterday.
Hi Andrew,
The only commit I see from you in the net/master branch is the partial fix
I referenced in the 'fixes' line (c21fbe29f858), from all I can tell, my fix is
still needed on top. Can you check again?
Arnd
[toc] | [prev] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2017-05-30 19:00 +0200 |
| Message-ID | <tMSEW-1o1-21@gated-at.bofh.it> |
| In reply to | #1652710 |
On Mon, May 29, 2017 at 11:06:51PM +0200, Arnd Bergmann wrote:
> On Mon, May 29, 2017 at 5:30 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> > On Mon, May 29, 2017 at 02:56:01PM +0200, Arnd Bergmann wrote:
> >> 'static' was not enough, the helpers must be 'static inline'
> >>
> >> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
> >> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
> >>
> >> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Hi Arnd
> >
> > Dave merged my fix yesterday.
>
> Hi Andrew,
>
> The only commit I see from you in the net/master branch is the partial fix
> I referenced in the 'fixes' line (c21fbe29f858), from all I can tell, my fix is
> still needed on top. Can you check again?
Hi Arnd
Yes, you are correct. Adding the static was enough to stop the 0-day
warnings, but they should also inline.
Andrew
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-05-30 20:10 +0200 |
| Subject | Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions |
| Message-ID | <tMTKG-2ga-19@gated-at.bofh.it> |
| In reply to | #1652509 |
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 29 May 2017 14:56:01 +0200
> 'static' was not enough, the helpers must be 'static inline'
>
> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
>
> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web