Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1652578

Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions

Show all headers | View raw

Hi Arnd,

Arnd Bergmann <arnd@arndb.de> writes:

> 'static' was not enough, the helpers must be 'static inline'
>
> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
>
> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Arnd Bergmann <arnd@arndb.de> - 2017-05-29 15:00 +0200
  Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-29 17:10 +0200
  Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Andrew Lunn <andrew@lunn.ch> - 2017-05-29 17:40 +0200
    Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Arnd Bergmann <arnd@arndb.de> - 2017-05-29 23:10 +0200
      Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions Andrew Lunn <andrew@lunn.ch> - 2017-05-30 19:00 +0200
  Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub  functions David Miller <davem@davemloft.net> - 2017-05-30 20:10 +0200

csiph-web