Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1652189 > unrolled thread
| Started by | Chen Guanqiao <chen.chenchacha@foxmail.com> |
|---|---|
| First post | 2017-05-28 20:10 +0200 |
| Last post | 2017-05-28 22:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?) Chen Guanqiao <chen.chenchacha@foxmail.com> - 2017-05-28 20:10 +0200
Re: [PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?) Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-05-28 22:10 +0200
| From | Chen Guanqiao <chen.chenchacha@foxmail.com> |
|---|---|
| Date | 2017-05-28 20:10 +0200 |
| Subject | [PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?) |
| Message-ID | <tMaNz-5p3-3@gated-at.bofh.it> |
Fix "symbol 'xxxxxxx' was not declared. Should it be static?" sparse warnings.
Signed-off-by: Chen Guanqiao <chen.chenchacha@foxmail.com>
---
drivers/staging/media/atomisp/i2c/lm3554.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/lm3554.c b/drivers/staging/media/atomisp/i2c/lm3554.c
index dd9c9c3ffff7..2b170c07aaba 100644
--- a/drivers/staging/media/atomisp/i2c/lm3554.c
+++ b/drivers/staging/media/atomisp/i2c/lm3554.c
@@ -497,7 +497,7 @@ static const struct v4l2_ctrl_ops ctrl_ops = {
.g_volatile_ctrl = lm3554_g_volatile_ctrl
};
-struct v4l2_ctrl_config lm3554_controls[] = {
+static const struct v4l2_ctrl_config lm3554_controls[] = {
{
.ops = &ctrl_ops,
.id = V4L2_CID_FLASH_TIMEOUT,
@@ -825,7 +825,7 @@ static int lm3554_gpio_uninit(struct i2c_client *client)
return 0;
}
-void *lm3554_platform_data_func(struct i2c_client *client)
+static void *lm3554_platform_data_func(struct i2c_client *client)
{
static struct lm3554_platform_data platform_data;
--
2.11.0
[toc] | [next] | [standalone]
| From | Alan Cox <gnomes@lxorguk.ukuu.org.uk> |
|---|---|
| Date | 2017-05-28 22:10 +0200 |
| Subject | Re: [PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?) |
| Message-ID | <tMcFI-6DJ-7@gated-at.bofh.it> |
| In reply to | #1652189 |
On Mon, 29 May 2017 02:06:41 +0800 Chen Guanqiao <chen.chenchacha@foxmail.com> wrote: > Fix "symbol 'xxxxxxx' was not declared. Should it be static?" sparse warnings. > > Signed-off-by: Chen Guanqiao <chen.chenchacha@foxmail.com> > --- Reviewed-by: Alan Cox <alan@linux.intel.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web