[PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?)

From	Chen Guanqiao <chen.chenchacha@foxmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?)
Date	2017-05-28 20:10 +0200
Message-ID	<tMaNz-5p3-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Fix "symbol 'xxxxxxx' was not declared. Should it be static?" sparse warnings.

Signed-off-by: Chen Guanqiao <chen.chenchacha@foxmail.com>
---
 drivers/staging/media/atomisp/i2c/lm3554.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/lm3554.c b/drivers/staging/media/atomisp/i2c/lm3554.c
index dd9c9c3ffff7..2b170c07aaba 100644
--- a/drivers/staging/media/atomisp/i2c/lm3554.c
+++ b/drivers/staging/media/atomisp/i2c/lm3554.c
@@ -497,7 +497,7 @@ static const struct v4l2_ctrl_ops ctrl_ops = {
 	.g_volatile_ctrl = lm3554_g_volatile_ctrl
 };
 
-struct v4l2_ctrl_config lm3554_controls[] = {
+static const struct v4l2_ctrl_config lm3554_controls[] = {
 	{
 	 .ops = &ctrl_ops,
 	 .id = V4L2_CID_FLASH_TIMEOUT,
@@ -825,7 +825,7 @@ static int lm3554_gpio_uninit(struct i2c_client *client)
 	return 0;
 }
 
-void *lm3554_platform_data_func(struct i2c_client *client)
+static void *lm3554_platform_data_func(struct i2c_client *client)
 {
 	static struct lm3554_platform_data platform_data;
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?) Chen Guanqiao <chen.chenchacha@foxmail.com> - 2017-05-28 20:10 +0200
  Re: [PATCH] staging: atomisp: lm3554: fix sparse warnings(was not  declared. Should it be static?) Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-05-28 22:10 +0200

csiph-web