Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653549 > unrolled thread
| Started by | Carlo Caione <carlo@caione.org> |
|---|---|
| First post | 2017-05-30 22:50 +0200 |
| Last post | 2017-06-02 14:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] HID: asus: Stop underlying hardware on remove Carlo Caione <carlo@caione.org> - 2017-05-30 22:50 +0200
Re: [PATCH] HID: asus: Stop underlying hardware on remove Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-02 09:40 +0200
Re: [PATCH] HID: asus: Stop underlying hardware on remove Jiri Kosina <jikos@kernel.org> - 2017-06-02 14:20 +0200
| From | Carlo Caione <carlo@caione.org> |
|---|---|
| Date | 2017-05-30 22:50 +0200 |
| Subject | [PATCH] HID: asus: Stop underlying hardware on remove |
| Message-ID | <tMWfw-3DM-11@gated-at.bofh.it> |
From: Carlo Caione <carlo@endlessm.com> We are missing a call to hid_hw_stop() on the remove hook. Among other things this is causing an Oops when (re-)starting GNOME / upowerd / ... after the module has been already rmmod-ed. Signed-off-by: Carlo Caione <carlo@endlessm.com> --- drivers/hid/hid-asus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 16df6cc..2e9642d 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -536,6 +536,8 @@ static void asus_remove(struct hid_device *hdev) drvdata->kbd_backlight->removed = true; cancel_work_sync(&drvdata->kbd_backlight->work); } + + hid_hw_stop(hdev); } static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc, -- 2.9.3
[toc] | [next] | [standalone]
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2017-06-02 09:40 +0200 |
| Message-ID | <tNPlE-6o8-23@gated-at.bofh.it> |
| In reply to | #1653549 |
On May 30 2017 or thereabouts, Carlo Caione wrote: > From: Carlo Caione <carlo@endlessm.com> > > We are missing a call to hid_hw_stop() on the remove hook. > Among other things this is causing an Oops when (re-)starting GNOME / > upowerd / ... after the module has been already rmmod-ed. Good catch: Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cheers, Benjamin > > Signed-off-by: Carlo Caione <carlo@endlessm.com> > --- > drivers/hid/hid-asus.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c > index 16df6cc..2e9642d 100644 > --- a/drivers/hid/hid-asus.c > +++ b/drivers/hid/hid-asus.c > @@ -536,6 +536,8 @@ static void asus_remove(struct hid_device *hdev) > drvdata->kbd_backlight->removed = true; > cancel_work_sync(&drvdata->kbd_backlight->work); > } > + > + hid_hw_stop(hdev); > } > > static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc, > -- > 2.9.3 >
[toc] | [prev] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2017-06-02 14:20 +0200 |
| Message-ID | <tNTIC-Vj-21@gated-at.bofh.it> |
| In reply to | #1653549 |
On Tue, 30 May 2017, Carlo Caione wrote: > From: Carlo Caione <carlo@endlessm.com> > > We are missing a call to hid_hw_stop() on the remove hook. > Among other things this is causing an Oops when (re-)starting GNOME / > upowerd / ... after the module has been already rmmod-ed. > > Signed-off-by: Carlo Caione <carlo@endlessm.com> Applied to for-4.12/upstream-fixes, thanks. -- Jiri Kosina SUSE Labs
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web