[PATCH] HID: asus: Stop underlying hardware on remove

From	Carlo Caione <carlo@caione.org>
Newsgroups	linux.kernel
Subject	[PATCH] HID: asus: Stop underlying hardware on remove
Date	2017-05-30 22:50 +0200
Message-ID	<tMWfw-3DM-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Carlo Caione <carlo@endlessm.com>

We are missing a call to hid_hw_stop() on the remove hook.
Among other things this is causing an Oops when (re-)starting GNOME /
upowerd / ... after the module has been already rmmod-ed.

Signed-off-by: Carlo Caione <carlo@endlessm.com>
---
 drivers/hid/hid-asus.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 16df6cc..2e9642d 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -536,6 +536,8 @@ static void asus_remove(struct hid_device *hdev)
 		drvdata->kbd_backlight->removed = true;
 		cancel_work_sync(&drvdata->kbd_backlight->work);
 	}
+
+	hid_hw_stop(hdev);
 }
 
 static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] HID: asus: Stop underlying hardware on remove Carlo Caione <carlo@caione.org> - 2017-05-30 22:50 +0200
  Re: [PATCH] HID: asus: Stop underlying hardware on remove Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-02 09:40 +0200
  Re: [PATCH] HID: asus: Stop underlying hardware on remove Jiri Kosina <jikos@kernel.org> - 2017-06-02 14:20 +0200

csiph-web