Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1652879 > unrolled thread
| Started by | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| First post | 2017-05-30 09:10 +0200 |
| Last post | 2017-05-31 20:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:10 +0200
Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 20:40 +0200
Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-31 18:40 +0200
Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-31 20:10 +0200
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-30 09:10 +0200 |
| Subject | [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards |
| Message-ID | <tMJrY-44F-21@gated-at.bofh.it> |
Commtech adapters need the MPIOs for internal purposes, and the gpio-exar driver already refused to pick them up. But there is actually no point in even creating the underlying platform device. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/gpio/gpio-exar.c | 3 --- drivers/tty/serial/8250/8250_exar.c | 4 +++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c index 081076771217..006a9a67c2a4 100644 --- a/drivers/gpio/gpio-exar.c +++ b/drivers/gpio/gpio-exar.c @@ -124,9 +124,6 @@ static int gpio_exar_probe(struct platform_device *pdev) void __iomem *p; int index, ret; - if (pcidev->vendor != PCI_VENDOR_ID_EXAR) - return -ENODEV; - /* * Map the pci device to get the register addresses. * We will need to read and write those registers to control diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 8984e8b2d524..c29c7e675890 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -245,7 +245,9 @@ pci_xr17v35x_setup(struct exar8250 *priv, struct pci_dev *pcidev, /* Setup Multipurpose Input/Output pins. */ setup_gpio(pcidev, p); - port->port.private_data = xr17v35x_register_gpio(pcidev); + if (pcidev->vendor == PCI_VENDOR_ID_EXAR) + port->port.private_data = + xr17v35x_register_gpio(pcidev); } return 0; -- 2.12.3
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-30 20:40 +0200 |
| Subject | Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards |
| Message-ID | <tMUdH-2qm-7@gated-at.bofh.it> |
| In reply to | #1652879 |
On Tue, May 30, 2017 at 10:01 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > Commtech adapters need the MPIOs for internal purposes, and the > gpio-exar driver already refused to pick them up. But there is actually > no point in even creating the underlying platform device. It still feels that partially you may do stuff here, like renaming to __xr17v35x_register_gpio() and creating xr17v35x_register_gpio() wrapper. > diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c > index 081076771217..006a9a67c2a4 100644 > --- a/drivers/gpio/gpio-exar.c > +++ b/drivers/gpio/gpio-exar.c > @@ -124,9 +124,6 @@ static int gpio_exar_probe(struct platform_device *pdev) > void __iomem *p; > int index, ret; > > - if (pcidev->vendor != PCI_VENDOR_ID_EXAR) > - return -ENODEV; > - > /* > * Map the pci device to get the register addresses. > * We will need to read and write those registers to control > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c > index 8984e8b2d524..c29c7e675890 100644 > --- a/drivers/tty/serial/8250/8250_exar.c > +++ b/drivers/tty/serial/8250/8250_exar.c > @@ -245,7 +245,9 @@ pci_xr17v35x_setup(struct exar8250 *priv, struct pci_dev *pcidev, > /* Setup Multipurpose Input/Output pins. */ > setup_gpio(pcidev, p); > > - port->port.private_data = xr17v35x_register_gpio(pcidev); > + if (pcidev->vendor == PCI_VENDOR_ID_EXAR) > + port->port.private_data = > + xr17v35x_register_gpio(pcidev); > } > > return 0; > -- > 2.12.3 > -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-31 18:40 +0200 |
| Subject | Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards |
| Message-ID | <tNeP8-7dL-5@gated-at.bofh.it> |
| In reply to | #1653473 |
On 2017-05-30 20:33, Andy Shevchenko wrote: > On Tue, May 30, 2017 at 10:01 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >> Commtech adapters need the MPIOs for internal purposes, and the >> gpio-exar driver already refused to pick them up. But there is actually >> no point in even creating the underlying platform device. > > It still feels that partially you may do stuff here, like > renaming to > __xr17v35x_register_gpio() > and creating > xr17v35x_register_gpio() wrapper. Sorry, that remains unrelated to the topic of this patch and would be unclean. If you want me to pull those refactorings out of patch 9, I need to write a separate patch - no problem. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-31 20:10 +0200 |
| Subject | Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards |
| Message-ID | <tNged-8ge-1@gated-at.bofh.it> |
| In reply to | #1654439 |
On Wed, May 31, 2017 at 7:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 2017-05-30 20:33, Andy Shevchenko wrote: >> On Tue, May 30, 2017 at 10:01 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>> Commtech adapters need the MPIOs for internal purposes, and the >>> gpio-exar driver already refused to pick them up. But there is actually >>> no point in even creating the underlying platform device. >> >> It still feels that partially you may do stuff here, like >> renaming to >> __xr17v35x_register_gpio() >> and creating >> xr17v35x_register_gpio() wrapper. > > Sorry, that remains unrelated to the topic of this patch and would be > unclean. If you want me to pull those refactorings out of patch 9, I > need to write a separate patch - no problem. Okay, I would go with separate patch, if maintainers are okay with this approach. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web