Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards
Date	2017-05-31 20:10 +0200
Message-ID	<tNged-8ge-1@gated-at.bofh.it> (permalink)
References	<tMJrX-44F-3@gated-at.bofh.it> <tMJrY-44F-21@gated-at.bofh.it> <tMUdH-2qm-7@gated-at.bofh.it> <tNeP8-7dL-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 31, 2017 at 7:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-05-30 20:33, Andy Shevchenko wrote:
>> On Tue, May 30, 2017 at 10:01 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> Commtech adapters need the MPIOs for internal purposes, and the
>>> gpio-exar driver already refused to pick them up. But there is actually
>>> no point in even creating the underlying platform device.
>>
>> It still feels that partially you may do stuff here, like
>> renaming to
>> __xr17v35x_register_gpio()
>> and creating
>> xr17v35x_register_gpio() wrapper.
>
> Sorry, that remains unrelated to the topic of this patch and would be
> unclean. If you want me to pull those refactorings out of patch 9, I
> need to write a separate patch - no problem.

Okay, I would go with separate patch, if maintainers are okay with
this approach.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:10 +0200
  Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a  GPIO device for Commtech cards Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 20:40 +0200
    Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a  GPIO device for Commtech cards Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-31 18:40 +0200
      Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a  GPIO device for Commtech cards Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-31 20:10 +0200

csiph-web