Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1651376 > unrolled thread
| Started by | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| First post | 2017-05-26 15:10 +0200 |
| Last post | 2017-05-26 20:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-26 15:10 +0200
Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-26 16:30 +0200
Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-26 20:50 +0200
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-26 15:10 +0200 |
| Subject | Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output |
| Message-ID | <tLna9-6jc-9@gated-at.bofh.it> |
Greg, On 2017-05-13 09:28, Jan Kiszka wrote: > This is the safe default for GPIOs with unknown external wiring. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > drivers/tty/serial/8250/8250_exar.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c > index 1270ff163f63..b4fa585156c7 100644 > --- a/drivers/tty/serial/8250/8250_exar.c > +++ b/drivers/tty/serial/8250/8250_exar.c > @@ -177,13 +177,13 @@ static void setup_gpio(u8 __iomem *p) > writeb(0x00, p + UART_EXAR_MPIOLVL_7_0); > writeb(0x00, p + UART_EXAR_MPIO3T_7_0); > writeb(0x00, p + UART_EXAR_MPIOINV_7_0); > - writeb(0x00, p + UART_EXAR_MPIOSEL_7_0); > + writeb(0xff, p + UART_EXAR_MPIOSEL_7_0); > writeb(0x00, p + UART_EXAR_MPIOOD_7_0); > writeb(0x00, p + UART_EXAR_MPIOINT_15_8); > writeb(0x00, p + UART_EXAR_MPIOLVL_15_8); > writeb(0x00, p + UART_EXAR_MPIO3T_15_8); > writeb(0x00, p + UART_EXAR_MPIOINV_15_8); > - writeb(0x00, p + UART_EXAR_MPIOSEL_15_8); > + writeb(0xff, p + UART_EXAR_MPIOSEL_15_8); > writeb(0x00, p + UART_EXAR_MPIOOD_15_8); > } > > Please drop from this tty-next, it may break Commtech adapters. I have an update ready. I may also send a fix on top if that is preferred, just let me know. Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-26 16:30 +0200 |
| Message-ID | <tLopA-70f-17@gated-at.bofh.it> |
| In reply to | #1651376 |
On Fri, May 26, 2017 at 4:04 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > Greg, > Please drop from this tty-next, it may break Commtech adapters. I have > an update ready. > > I may also send a fix on top if that is preferred, just let me know. AFAIK what is in tty-next is left there, so, looks like latter is the option. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-26 20:50 +0200 |
| Message-ID | <tLstb-115-3@gated-at.bofh.it> |
| In reply to | #1651376 |
On Fri, May 26, 2017 at 03:04:26PM +0200, Jan Kiszka wrote: > Greg, > > On 2017-05-13 09:28, Jan Kiszka wrote: > > This is the safe default for GPIOs with unknown external wiring. > > > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > > --- > > drivers/tty/serial/8250/8250_exar.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c > > index 1270ff163f63..b4fa585156c7 100644 > > --- a/drivers/tty/serial/8250/8250_exar.c > > +++ b/drivers/tty/serial/8250/8250_exar.c > > @@ -177,13 +177,13 @@ static void setup_gpio(u8 __iomem *p) > > writeb(0x00, p + UART_EXAR_MPIOLVL_7_0); > > writeb(0x00, p + UART_EXAR_MPIO3T_7_0); > > writeb(0x00, p + UART_EXAR_MPIOINV_7_0); > > - writeb(0x00, p + UART_EXAR_MPIOSEL_7_0); > > + writeb(0xff, p + UART_EXAR_MPIOSEL_7_0); > > writeb(0x00, p + UART_EXAR_MPIOOD_7_0); > > writeb(0x00, p + UART_EXAR_MPIOINT_15_8); > > writeb(0x00, p + UART_EXAR_MPIOLVL_15_8); > > writeb(0x00, p + UART_EXAR_MPIO3T_15_8); > > writeb(0x00, p + UART_EXAR_MPIOINV_15_8); > > - writeb(0x00, p + UART_EXAR_MPIOSEL_15_8); > > + writeb(0xff, p + UART_EXAR_MPIOSEL_15_8); > > writeb(0x00, p + UART_EXAR_MPIOOD_15_8); > > } > > > > > > Please drop from this tty-next, it may break Commtech adapters. I have > an update ready. > > I may also send a fix on top if that is preferred, just let me know. I need a fixup patch, I can't drop a patch, only revert it. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web