Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output
Date	2017-05-26 20:50 +0200
Message-ID	<tLstb-115-3@gated-at.bofh.it> (permalink)
References	<tGzF0-rm-5@gated-at.bofh.it> <tGzOF-uC-7@gated-at.bofh.it> <tLna9-6jc-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 26, 2017 at 03:04:26PM +0200, Jan Kiszka wrote:
> Greg,
> 
> On 2017-05-13 09:28, Jan Kiszka wrote:
> > This is the safe default for GPIOs with unknown external wiring.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> >  drivers/tty/serial/8250/8250_exar.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
> > index 1270ff163f63..b4fa585156c7 100644
> > --- a/drivers/tty/serial/8250/8250_exar.c
> > +++ b/drivers/tty/serial/8250/8250_exar.c
> > @@ -177,13 +177,13 @@ static void setup_gpio(u8 __iomem *p)
> >  	writeb(0x00, p + UART_EXAR_MPIOLVL_7_0);
> >  	writeb(0x00, p + UART_EXAR_MPIO3T_7_0);
> >  	writeb(0x00, p + UART_EXAR_MPIOINV_7_0);
> > -	writeb(0x00, p + UART_EXAR_MPIOSEL_7_0);
> > +	writeb(0xff, p + UART_EXAR_MPIOSEL_7_0);
> >  	writeb(0x00, p + UART_EXAR_MPIOOD_7_0);
> >  	writeb(0x00, p + UART_EXAR_MPIOINT_15_8);
> >  	writeb(0x00, p + UART_EXAR_MPIOLVL_15_8);
> >  	writeb(0x00, p + UART_EXAR_MPIO3T_15_8);
> >  	writeb(0x00, p + UART_EXAR_MPIOINV_15_8);
> > -	writeb(0x00, p + UART_EXAR_MPIOSEL_15_8);
> > +	writeb(0xff, p + UART_EXAR_MPIOSEL_15_8);
> >  	writeb(0x00, p + UART_EXAR_MPIOOD_15_8);
> >  }
> >  
> > 
> 
> Please drop from this tty-next, it may break Commtech adapters. I have
> an update ready.
> 
> I may also send a fix on top if that is preferred, just let me know.

I need a fixup patch, I can't drop a patch, only revert it.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-26 15:10 +0200
  Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-26 16:30 +0200
  Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-26 20:50 +0200

csiph-web