Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650659 > unrolled thread
| Started by | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2017-05-25 19:00 +0200 |
| Last post | 2017-05-26 15:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings Greg KH <gregkh@linuxfoundation.org> - 2017-05-25 19:00 +0200
Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings Laurentiu Tudor <laurentiu.tudor@nxp.com> - 2017-05-26 15:30 +0200
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-25 19:00 +0200 |
| Subject | Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings |
| Message-ID | <tL4hd-2di-27@gated-at.bofh.it> |
On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor@nxp.com wrote: > From: Laurentiu Tudor <laurentiu.tudor@nxp.com> Your subject line is very odd, please use the 'v2' marking properly... > > Remove several unneeded #includes, forward > declarations and fix several issues reported > by checkpatch.pl --strict, such as: > - kfree(NULL) is safe and check is not required > - macro argument reuse may cause possible side effects > - enclose macro params in parens to avoid precedence issues > - coding style These, as always, need to be broken up into one-patch-per-type-of-thing, you have been in the staging tree long enough to know this :( Please do this first, then we can consider the rest of the series... thanks, greg k-h
[toc] | [next] | [standalone]
| From | Laurentiu Tudor <laurentiu.tudor@nxp.com> |
|---|---|
| Date | 2017-05-26 15:30 +0200 |
| Message-ID | <tLntv-6pE-1@gated-at.bofh.it> |
| In reply to | #1650659 |
Hi Greg, On 05/25/2017 07:58 PM, Greg KH wrote: > On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tudor@nxp.com> > > Your subject line is very odd, please use the 'v2' marking properly... > >> >> Remove several unneeded #includes, forward >> declarations and fix several issues reported >> by checkpatch.pl --strict, such as: >> - kfree(NULL) is safe and check is not required >> - macro argument reuse may cause possible side effects >> - enclose macro params in parens to avoid precedence issues >> - coding style > > These, as always, need to be broken up into one-patch-per-type-of-thing, > you have been in the staging tree long enough to know this :( Sorry about that. Will take care of all your comments in the next respin. --- Thanks & Best Regards, Laurentiu
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web