Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings

From	Laurentiu Tudor <laurentiu.tudor@nxp.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings
Date	2017-05-26 15:30 +0200
Message-ID	<tLntv-6pE-1@gated-at.bofh.it> (permalink)
References	<tL4hc-2di-9@gated-at.bofh.it> <tL4hd-2di-29@gated-at.bofh.it> <tL4hd-2di-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Greg,

On 05/25/2017 07:58 PM, Greg KH wrote:
> On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor@nxp.com wrote:
>> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>
> Your subject line is very odd, please use the 'v2' marking properly...
>
>>
>> Remove several unneeded #includes, forward
>> declarations and fix several issues reported
>> by checkpatch.pl --strict, such as:
>>   - kfree(NULL) is safe and check is not required
>>   - macro argument reuse may cause possible side effects
>>   - enclose macro params in parens to avoid precedence issues
>>   - coding style
>
> These, as always, need to be broken up into one-patch-per-type-of-thing,
> you have been in the staging tree long enough to know this :(

Sorry about that. Will take care of all your comments in the next respin.

---
Thanks & Best Regards, Laurentiu

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl  warnings Greg KH <gregkh@linuxfoundation.org> - 2017-05-25 19:00 +0200
  Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl  warnings Laurentiu Tudor <laurentiu.tudor@nxp.com> - 2017-05-26 15:30 +0200

csiph-web