Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1650975 > unrolled thread

Re: linux-next: build warning after merge of the drivers-x86 tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2017-05-26 01:40 +0200
Last post2017-05-26 11:30 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-26 01:40 +0200
    Re: linux-next: build warning after merge of the drivers-x86 tree Arnd Bergmann <arnd@arndb.de> - 2017-05-26 10:30 +0200
      Re: linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-26 10:40 +0200
        Re: linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-26 11:20 +0200
          Re: linux-next: build warning after merge of the drivers-x86 tree Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-26 12:00 +0200
        Re: linux-next: build warning after merge of the drivers-x86 tree Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-26 11:30 +0200

#1650975 — Re: linux-next: build warning after merge of the drivers-x86 tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2017-05-26 01:40 +0200
SubjectRe: linux-next: build warning after merge of the drivers-x86 tree
Message-ID<tLawi-6pJ-21@gated-at.bofh.it>
Hi Andy,

On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@infradead.org> wrote:
> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:  
> >>
> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
> >> allmodconfig) produced this warning:
> >>
> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
> >>  static ssize_t touchpad_store(struct device *dev,
> >>                 ^
> >>
> >> Introduced by commit
> >>
> >>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")  
> >
> >
> > Andy, you warned me about this and I had forgotten before I included it in next.
> >
> > Would you like to drop this change, or drop the touchpad_store function?  
> 
> I would go with Arnd's patch if he respins one addressing my comment.

Any progress on this?

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1651183

FromArnd Bergmann <arnd@arndb.de>
Date2017-05-26 10:30 +0200
Message-ID<tLiNd-3tM-73@gated-at.bofh.it>
In reply to#1650975
On Fri, May 26, 2017 at 1:34 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>> On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@infradead.org> wrote:
>> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> >>
>> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> >> allmodconfig) produced this warning:
>> >>
>> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
>> >>  static ssize_t touchpad_store(struct device *dev,
>> >>                 ^
>> >>
>> >> Introduced by commit
>> >>
>> >>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
>> >
>> >
>> > Andy, you warned me about this and I had forgotten before I included it in next.
>> >
>> > Would you like to drop this change, or drop the touchpad_store function?
>>
>> I would go with Arnd's patch if he respins one addressing my comment.
>
> Any progress on this?

Andy wrote that he committed an updated patch on May 23. The git tree
at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
appears to currently contain an older state from May 15.

        Arnd

[toc] | [prev] | [next] | [standalone]

#1651202

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2017-05-26 10:40 +0200
Message-ID<tLiWS-3x5-29@gated-at.bofh.it>
In reply to#1651183
Hi Arnd,

On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>
> Andy wrote that he committed an updated patch on May 23. The git tree
> at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
> appears to currently contain an older state from May 15.

So just not pushed out yet.  That's fine, I will hopefully notice when
it turns up.  Just checking that it wasn't forgotten.

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]

#1651245

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2017-05-26 11:20 +0200
Message-ID<tLjzz-41p-1@gated-at.bofh.it>
In reply to#1651202
Hi Andy,

On Fri, 26 May 2017 12:04:47 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann <arnd@arndb.de> wrote:  
> >>
> >> Andy wrote that he committed an updated patch on May 23. The git tree
> >> at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
> >> appears to currently contain an older state from May 15.  
> >
> > So just not pushed out yet.  That's fine, I will hopefully notice when
> > it turns up.  Just checking that it wasn't forgotten.  
> 
> No, it wasn't, it it in testing branch, I 'm about to push to for-next.

Thanks.  No rush.

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]

#1651279

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-05-26 12:00 +0200
Message-ID<tLkci-4g5-21@gated-at.bofh.it>
In reply to#1651245
On Fri, May 26, 2017 at 12:07 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Andy,
>
> On Fri, 26 May 2017 12:04:47 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>>
>> On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> > On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>> >>
>> >> Andy wrote that he committed an updated patch on May 23. The git tree
>> >> at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
>> >> appears to currently contain an older state from May 15.
>> >
>> > So just not pushed out yet.  That's fine, I will hopefully notice when
>> > it turns up.  Just checking that it wasn't forgotten.
>>
>> No, it wasn't, it it in testing branch, I 'm about to push to for-next.
>
> Thanks.  No rush.

Pushed.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1651248

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-05-26 11:30 +0200
Message-ID<tLjzz-41p-3@gated-at.bofh.it>
In reply to#1651202
On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> Andy wrote that he committed an updated patch on May 23. The git tree
>> at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
>> appears to currently contain an older state from May 15.
>
> So just not pushed out yet.  That's fine, I will hopefully notice when
> it turns up.  Just checking that it wasn't forgotten.

No, it wasn't, it it in testing branch, I 'm about to push to for-next.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web