Re: linux-next: build warning after merge of the drivers-x86 tree

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: linux-next: build warning after merge of the drivers-x86 tree
Date	2017-05-26 10:30 +0200
Message-ID	<tLiNd-3tM-73@gated-at.bofh.it> (permalink)
References	<tIGM1-4u0-11@gated-at.bofh.it> <tIYfU-57-3@gated-at.bofh.it> <tJZWh-z3-1@gated-at.bofh.it> <tLawi-6pJ-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 26, 2017 at 1:34 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>> On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@infradead.org> wrote:
>> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> >>
>> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> >> allmodconfig) produced this warning:
>> >>
>> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
>> >>  static ssize_t touchpad_store(struct device *dev,
>> >>                 ^
>> >>
>> >> Introduced by commit
>> >>
>> >>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
>> >
>> >
>> > Andy, you warned me about this and I had forgotten before I included it in next.
>> >
>> > Would you like to drop this change, or drop the touchpad_store function?
>>
>> I would go with Arnd's patch if he respins one addressing my comment.
>
> Any progress on this?

Andy wrote that he committed an updated patch on May 23. The git tree
at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
appears to currently contain an older state from May 15.

        Arnd

Thread

Re: linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-26 01:40 +0200
  Re: linux-next: build warning after merge of the drivers-x86 tree Arnd Bergmann <arnd@arndb.de> - 2017-05-26 10:30 +0200
    Re: linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-26 10:40 +0200
      Re: linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-26 11:20 +0200
        Re: linux-next: build warning after merge of the drivers-x86 tree Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-26 12:00 +0200
      Re: linux-next: build warning after merge of the drivers-x86 tree Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-26 11:30 +0200

csiph-web