Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1651068 > unrolled thread

Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning

Started byNick Desaulniers <nick.desaulniers@gmail.com>
First post2017-05-26 06:20 +0200
Last post2017-05-26 06:20 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-26 06:20 +0200

#1651068 — Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning

FromNick Desaulniers <nick.desaulniers@gmail.com>
Date2017-05-26 06:20 +0200
SubjectRe: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning
Message-ID<tLeTf-13U-5@gated-at.bofh.it>
On Wed, May 24, 2017 at 05:16:18PM +0900, Sergey Senozhatsky wrote:
> On (05/23/17 22:38), Nick Desaulniers wrote:
> > Fixes the following warning, found with Clang:
> well, no objections from my side. MM seems to be getting more and
> more `__maybe_unused' annotations because of clang.

Indeed, but does find bugs when this warning pops up unexpected (unlike
in this particular instance). See:

https://patchwork.kernel.org/patch/9738897/
https://www.spinics.net/lists/intel-gfx/msg128737.html

TL;DR
>>> You have actually uncovered a bug here where the call is not
>>> supposed to be optional in the first place.

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web