Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning

From	Nick Desaulniers <nick.desaulniers@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning
Date	2017-05-26 06:20 +0200
Message-ID	<tLeTf-13U-5@gated-at.bofh.it> (permalink)
References	<tKxlf-6tH-1@gated-at.bofh.it> <tKzGq-8dC-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 24, 2017 at 05:16:18PM +0900, Sergey Senozhatsky wrote:
> On (05/23/17 22:38), Nick Desaulniers wrote:
> > Fixes the following warning, found with Clang:
> well, no objections from my side. MM seems to be getting more and
> more `__maybe_unused' annotations because of clang.

Indeed, but does find bugs when this warning pops up unexpected (unlike
in this particular instance). See:

https://patchwork.kernel.org/patch/9738897/
https://www.spinics.net/lists/intel-gfx/msg128737.html

TL;DR
>>> You have actually uncovered a bug here where the call is not
>>> supposed to be optional in the first place.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-26 06:20 +0200

csiph-web