Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1651996 > unrolled thread

Re: [PATCH net-next] net: stmmac: use correct pointer when printing normal descriptor ring

Started byAndy Shevchenko <andy.shevchenko@gmail.com>
First post2017-05-28 00:10 +0200
Last post2017-05-28 00:10 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH net-next] net: stmmac: use correct pointer when printing  normal descriptor ring Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-28 00:10 +0200

#1651996 — Re: [PATCH net-next] net: stmmac: use correct pointer when printing normal descriptor ring

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-05-28 00:10 +0200
SubjectRe: [PATCH net-next] net: stmmac: use correct pointer when printing normal descriptor ring
Message-ID<tLS4i-1vx-17@gated-at.bofh.it>
On Tue, May 9, 2017 at 7:52 PM, Niklas Cassel <niklas.cassel@axis.com> wrote:
> From: Niklas Cassel <niklas.cassel@axis.com>

Commit message?

>                         seq_printf(seq, "%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> -                                  i, (unsigned int)virt_to_phys(ep),
> +                                  i, (unsigned int)virt_to_phys(p),

There is should not be casting. Pointer might be 64-bit, thus %pap
must be used instead with a reference to the physical address.

>                                    le32_to_cpu(p->des0), le32_to_cpu(p->des1),
>                                    le32_to_cpu(p->des2), le32_to_cpu(p->des3));
>                         p++;

-- 
With Best Regards,
Andy Shevchenko

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web