Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1651996

Re: [PATCH net-next] net: stmmac: use correct pointer when printing normal descriptor ring

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next] net: stmmac: use correct pointer when printing normal descriptor ring
Date 2017-05-28 00:10 +0200
Message-ID <tLS4i-1vx-17@gated-at.bofh.it> (permalink)
References <tFgEq-4pa-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, May 9, 2017 at 7:52 PM, Niklas Cassel <niklas.cassel@axis.com> wrote:
> From: Niklas Cassel <niklas.cassel@axis.com>

Commit message?

>                         seq_printf(seq, "%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> -                                  i, (unsigned int)virt_to_phys(ep),
> +                                  i, (unsigned int)virt_to_phys(p),

There is should not be casting. Pointer might be 64-bit, thus %pap
must be used instead with a reference to the physical address.

>                                    le32_to_cpu(p->des0), le32_to_cpu(p->des1),
>                                    le32_to_cpu(p->des2), le32_to_cpu(p->des3));
>                         p++;

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH net-next] net: stmmac: use correct pointer when printing  normal descriptor ring Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-28 00:10 +0200

csiph-web