Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650716 > unrolled thread
| Started by | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
|---|---|
| First post | 2017-05-25 20:30 +0200 |
| Last post | 2017-05-25 22:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 05/20] ARM: dts: efm32: Add generic compatible string for I2C EEPROM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2017-05-25 20:30 +0200
Re: [PATCH v5 05/20] ARM: dts: efm32: Add generic compatible string for I2C EEPROM Javier Martinez Canillas <javier@dowhile0.org> - 2017-05-25 22:20 +0200
| From | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
|---|---|
| Date | 2017-05-25 20:30 +0200 |
| Subject | Re: [PATCH v5 05/20] ARM: dts: efm32: Add generic compatible string for I2C EEPROM |
| Message-ID | <tL5Gi-3fL-5@gated-at.bofh.it> |
Hello, On Tue, May 23, 2017 at 03:34:33PM +0200, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org> Assuming the of-table patch is accepted this can have my: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Otherwise I'm not convinced this is worth the churn. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
[toc] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@dowhile0.org> |
|---|---|
| Date | 2017-05-25 22:20 +0200 |
| Message-ID | <tL7oJ-4nj-3@gated-at.bofh.it> |
| In reply to | #1650716 |
Hello Uwe, On Thu, May 25, 2017 at 8:29 PM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Hello, > > On Tue, May 23, 2017 at 03:34:33PM +0200, Javier Martinez Canillas wrote: >> The at24 driver allows to register I2C EEPROM chips using different vendor >> and devices, but the I2C subsystem does not take the vendor into account >> when matching using the I2C table since it only has device entries. >> >> But when matching using an OF table, both the vendor and device has to be >> taken into account so the driver defines only a set of compatible strings >> using the "atmel" vendor as a generic fallback for compatible I2C devices. >> >> So add this generic fallback to the device node compatible string to make >> the device to match the driver using the OF device ID table. >> >> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org> > > Assuming the of-table patch is accepted this can have my: > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Thanks a lot for the Ack. > Otherwise I'm not convinced this is worth the churn. > Both changes are needed in order to make sure that the driver and DTS won't regress when the I2C core is modified to report a proper MODALIAS for I2C devices registered via OF. > Thanks > Uwe > Best regards, Javier
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web