Re: [PATCH v5 05/20] ARM: dts: efm32: Add generic compatible string for I2C EEPROM

From	Javier Martinez Canillas <javier@dowhile0.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 05/20] ARM: dts: efm32: Add generic compatible string for I2C EEPROM
Date	2017-05-25 22:20 +0200
Message-ID	<tL7oJ-4nj-3@gated-at.bofh.it> (permalink)
References	<tKicx-3OV-3@gated-at.bofh.it> <tKicy-3OV-21@gated-at.bofh.it> <tL5Gi-3fL-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Uwe,

On Thu, May 25, 2017 at 8:29 PM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Hello,
>
> On Tue, May 23, 2017 at 03:34:33PM +0200, Javier Martinez Canillas wrote:
>> The at24 driver allows to register I2C EEPROM chips using different vendor
>> and devices, but the I2C subsystem does not take the vendor into account
>> when matching using the I2C table since it only has device entries.
>>
>> But when matching using an OF table, both the vendor and device has to be
>> taken into account so the driver defines only a set of compatible strings
>> using the "atmel" vendor as a generic fallback for compatible I2C devices.
>>
>> So add this generic fallback to the device node compatible string to make
>> the device to match the driver using the OF device ID table.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
>
> Assuming the of-table patch is accepted this can have my:
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>

Thanks a lot for the Ack.

> Otherwise I'm not convinced this is worth the churn.
>

Both changes are needed in order to make sure that the driver and DTS
won't regress when the I2C core is modified to report a proper
MODALIAS for I2C devices registered via OF.

> Thanks
> Uwe
>

Best regards,
Javier

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 05/20] ARM: dts: efm32: Add generic compatible string  for I2C EEPROM Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-05-25 20:30 +0200
  Re: [PATCH v5 05/20] ARM: dts: efm32: Add generic compatible string  for I2C EEPROM Javier Martinez Canillas <javier@dowhile0.org> - 2017-05-25 22:20 +0200

csiph-web