Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650517 > unrolled thread
| Started by | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2017-05-25 15:50 +0200 |
| Last post | 2017-05-25 19:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-25 15:50 +0200
Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-25 18:40 +0200
Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-25 19:00 +0200
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-25 15:50 +0200 |
| Subject | Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list |
| Message-ID | <tL1jj-pv-5@gated-at.bofh.it> |
On Tue, May 23, 2017 at 05:07:41PM -0700, Dmitry Torokhov wrote:
> We should only add section attribute to the list of section attributes
> if we successfully created corresponding sysfs attribute.
>
> Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/firmware/google/vpd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Next time, can you split this up into 2 series, one for the current
kernel, and the rest for the "next" release? I've tried to split them
up myself here, hopefully it works...
thanks,
greg k-h
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-05-25 18:40 +0200 |
| Message-ID | <tL3XQ-26c-13@gated-at.bofh.it> |
| In reply to | #1650517 |
On Thu, May 25, 2017 at 03:40:58PM +0200, Greg Kroah-Hartman wrote:
> On Tue, May 23, 2017 at 05:07:41PM -0700, Dmitry Torokhov wrote:
> > We should only add section attribute to the list of section attributes
> > if we successfully created corresponding sysfs attribute.
> >
> > Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Reviewed-by: Guenter Roeck <groeck@chromium.org>
> > ---
> > drivers/firmware/google/vpd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Next time, can you split this up into 2 series, one for the current
> kernel, and the rest for the "next" release? I've tried to split them
> up myself here, hopefully it works...
OK, I will. It is just I did not consider either of issues serious
enough so they could not wait for next release: failure to allocate tiny
amounts of memory is impossible to trigger with current kernels. Same
goes for the other patches. For example, one needs to not only manage to
get sysfs attribute creation to fail, but also then unload the driver,
to trigger the issue. Unlikely to happen in real life.
Thanks.
--
Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-25 19:00 +0200 |
| Message-ID | <tL4hc-2di-25@gated-at.bofh.it> |
| In reply to | #1650638 |
On Thu, May 25, 2017 at 09:35:25AM -0700, Dmitry Torokhov wrote:
> On Thu, May 25, 2017 at 03:40:58PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, May 23, 2017 at 05:07:41PM -0700, Dmitry Torokhov wrote:
> > > We should only add section attribute to the list of section attributes
> > > if we successfully created corresponding sysfs attribute.
> > >
> > > Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > Reviewed-by: Guenter Roeck <groeck@chromium.org>
> > > ---
> > > drivers/firmware/google/vpd.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Next time, can you split this up into 2 series, one for the current
> > kernel, and the rest for the "next" release? I've tried to split them
> > up myself here, hopefully it works...
>
> OK, I will. It is just I did not consider either of issues serious
> enough so they could not wait for next release: failure to allocate tiny
> amounts of memory is impossible to trigger with current kernels. Same
> goes for the other patches. For example, one needs to not only manage to
> get sysfs attribute creation to fail, but also then unload the driver,
> to trigger the issue. Unlikely to happen in real life.
Ah, ok, that would have been good to know too :)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web