Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list
Date	2017-05-25 19:00 +0200
Message-ID	<tL4hc-2di-25@gated-at.bofh.it> (permalink)
References	<tKs2e-2wM-17@gated-at.bofh.it> <tL1jj-pv-5@gated-at.bofh.it> <tL3XQ-26c-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 25, 2017 at 09:35:25AM -0700, Dmitry Torokhov wrote:
> On Thu, May 25, 2017 at 03:40:58PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, May 23, 2017 at 05:07:41PM -0700, Dmitry Torokhov wrote:
> > > We should only add section attribute to the list of section attributes
> > > if we successfully created corresponding sysfs attribute.
> > > 
> > > Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > Reviewed-by: Guenter Roeck <groeck@chromium.org>
> > > ---
> > >  drivers/firmware/google/vpd.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Next time, can you split this up into 2 series, one for the current
> > kernel, and the rest for the "next" release?  I've tried to split them
> > up myself here, hopefully it works...
> 
> OK, I will. It is just I did not consider either of issues serious
> enough so they could not wait for next release: failure to allocate tiny
> amounts of memory is impossible to trigger with current kernels. Same
> goes for the other patches. For example, one needs to not only manage to
> get sysfs attribute creation to fail, but also then unload the driver,
> to trigger the issue. Unlikely to happen in real life.

Ah, ok, that would have been good to know too :)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes  to the list Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-25 15:50 +0200
  Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes  to the list Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-25 18:40 +0200
    Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes  to the list Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-25 19:00 +0200

csiph-web