Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1650464 > unrolled thread

[PATCH 00/21] liblockdep fixes for v4.12

Started by"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
First post2017-05-25 15:00 +0200
Last post2017-05-28 11:20 +0200
Articles 16 on this page of 36 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/21] liblockdep fixes for v4.12 "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:00 +0200
    [PATCH 10/21] tools: add install make target for liblockdep "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:00 +0200
      [tip:locking/core] tools: Add install make target for liblockdep tip-bot for Alexander Sverdlin <tipbot@zytor.com> - 2017-06-05 11:20 +0200
    [PATCH 06/21] liblockdep: Fix 'set but not used' warnings "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:00 +0200
      [tip:locking/core] tools/lib/lockdep: Fix 'set but not used'  warnings tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:10 +0200
    [PATCH 03/21] liblockdep: Define the ARRAY_SIZE() macro "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:00 +0200
      [tip:locking/core] tools/lib/lockdep: Define the ARRAY_SIZE() macro tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:10 +0200
    [PATCH 11/21] tools: liblockdep: Don't mix fd-based and stream IO "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/lib/lockdep: Don't mix fd-based and stream  IO tip-bot for Alexander Sverdlin <tipbot@zytor.com> - 2017-06-05 11:20 +0200
    [PATCH 19/21] tools include: add IS_ERR_OR_NULL to err.h "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/include: Add IS_ERR_OR_NULL to err.h "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
    [PATCH 09/21] MAINTAINERS: update email for Sasha Levin "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] MAINTAINERS: Update email for Sasha Levin "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:10 +0200
    [PATCH 04/21] liblockdep: Enable -Wall by default "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/lib/lockdep: Enable -Wall by default tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:10 +0200
    [PATCH 12/21] tools: liblockdep: fix compilation for 4.11 "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/lib/lockdep: Fix compilation for 4.11 "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
    [PATCH 21/21] tools: liblockdep: hide liblockdep output from test  results "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/lib/lockdep: Hide liblockdep output from  test results "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
    [PATCH 14/21] tools: liblockdep: Remove double-quotes from soname "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/lib/lockdep: Remove double-quotes from  soname tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:20 +0200
    [PATCH 17/21] tools: liblockdep: include err.h "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/lib/lockdep: Include err.h "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
    [PATCH 15/21] tools: liblockdep: Use LDFLAGS "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/lib/lockdep: Use LDFLAGS tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:20 +0200
    [PATCH 20/21] tools: liblockdep: add dummy current_gfp_context() "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/lib/lockdep: Add dummy  current_gfp_context() "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
    [PATCH 18/21] tools: liblockdep: add empty  __is_[module,kernel]_percpu_address "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/lib/lockdep: Add empty  __is_[module,kernel]_percpu_address "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
    [PATCH 07/21] liblockdep: Fix 'defined but not used' warning for  init_utsname() "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
      [tip:locking/core] tools/lib/lockdep: Fix 'defined but not used'  warning for init_utsname() tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:10 +0200
    Re: [PATCH 00/21] liblockdep fixes for v4.12 Ingo Molnar <mingo@kernel.org> - 2017-05-26 09:00 +0200
      Re: [PATCH 00/21] liblockdep fixes for v4.12 "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-26 13:00 +0200
        Re: [PATCH 00/21] liblockdep fixes for v4.12 Ingo Molnar <mingo@kernel.org> - 2017-05-26 13:30 +0200
          Re: [PATCH 00/21] liblockdep fixes for v4.12 "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-26 13:50 +0200
            Re: [PATCH 00/21] liblockdep fixes for v4.12 Ingo Molnar <mingo@kernel.org> - 2017-05-28 11:20 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1657439 — [tip:locking/core] tools/lib/lockdep: Remove double-quotes from soname

Fromtip-bot for Ben Hutchings <tipbot@zytor.com>
Date2017-06-05 11:20 +0200
Subject[tip:locking/core] tools/lib/lockdep: Remove double-quotes from soname
Message-ID<tOWl4-12Q-33@gated-at.bofh.it>
In reply to#1650479
Commit-ID:  e3addcc087d1ca398afbdefa3e671d580b026a71
Gitweb:     http://git.kernel.org/tip/e3addcc087d1ca398afbdefa3e671d580b026a71
Author:     Ben Hutchings <ben@decadent.org.uk>
AuthorDate: Thu, 25 May 2017 12:58:49 +0000
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 5 Jun 2017 09:28:10 +0200

tools/lib/lockdep: Remove double-quotes from soname

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: a.p.zijlstra@chello.nl
Link: http://lkml.kernel.org/r/20170525130005.5947-15-alexander.levin@verizon.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/lib/lockdep/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile
index e5e64d6..ce21b94 100644
--- a/tools/lib/lockdep/Makefile
+++ b/tools/lib/lockdep/Makefile
@@ -101,7 +101,7 @@ include $(srctree)/tools/build/Makefile.include
 
 do_compile_shared_library =			\
 	($(print_shared_lib_compile)		\
-	$(CC) --shared $^ -o $@ -lpthread -ldl -Wl,-soname='"$(@F)"';$(shell ln -sf $(@F) $(@D)/liblockdep.so))
+	$(CC) --shared $^ -o $@ -lpthread -ldl -Wl,-soname='$(@F)';$(shell ln -sf $(@F) $(@D)/liblockdep.so))
 
 do_build_static_lib =				\
 	($(print_static_lib_build)		\

[toc] | [prev] | [next] | [standalone]

#1650480 — [PATCH 17/21] tools: liblockdep: include err.h

From"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Date2017-05-25 15:10 +0200
Subject[PATCH 17/21] tools: liblockdep: include err.h
Message-ID<tL0GC-c1-33@gated-at.bofh.it>
In reply to#1650464
This provides PTR_ERR() now used by lockdep.

Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
 tools/lib/lockdep/uinclude/linux/kernel.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/lib/lockdep/uinclude/linux/kernel.h b/tools/lib/lockdep/uinclude/linux/kernel.h
index faa98cc7971a..75ff4b1bbcac 100644
--- a/tools/lib/lockdep/uinclude/linux/kernel.h
+++ b/tools/lib/lockdep/uinclude/linux/kernel.h
@@ -6,6 +6,7 @@
 #include <linux/rcu.h>
 #include <linux/hardirq.h>
 #include <linux/kern_levels.h>
+#include <linux/err.h>
 
 #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
 
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1657428 — [tip:locking/core] tools/lib/lockdep: Include err.h

From"tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com>
Date2017-06-05 11:20 +0200
Subject[tip:locking/core] tools/lib/lockdep: Include err.h
Message-ID<tOWl3-12Q-3@gated-at.bofh.it>
In reply to#1650480
Commit-ID:  f9155dd8d9281adac4d8c95ca66f7db22cd292e1
Gitweb:     http://git.kernel.org/tip/f9155dd8d9281adac4d8c95ca66f7db22cd292e1
Author:     Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com>
AuthorDate: Thu, 25 May 2017 12:58:53 +0000
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 5 Jun 2017 09:28:11 +0200

tools/lib/lockdep: Include err.h

This provides PTR_ERR() now used by lockdep.

Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: a.p.zijlstra@chello.nl
Cc: ben@decadent.org.uk
Link: http://lkml.kernel.org/r/20170525130005.5947-18-alexander.levin@verizon.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/lib/lockdep/uinclude/linux/kernel.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/lib/lockdep/uinclude/linux/kernel.h b/tools/lib/lockdep/uinclude/linux/kernel.h
index faa98cc..75ff4b1 100644
--- a/tools/lib/lockdep/uinclude/linux/kernel.h
+++ b/tools/lib/lockdep/uinclude/linux/kernel.h
@@ -6,6 +6,7 @@
 #include <linux/rcu.h>
 #include <linux/hardirq.h>
 #include <linux/kern_levels.h>
+#include <linux/err.h>
 
 #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))

[toc] | [prev] | [next] | [standalone]

#1650482 — [PATCH 15/21] tools: liblockdep: Use LDFLAGS

From"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Date2017-05-25 15:10 +0200
Subject[PATCH 15/21] tools: liblockdep: Use LDFLAGS
Message-ID<tL0GD-c1-43@gated-at.bofh.it>
In reply to#1650464
From: Ben Hutchings <ben@decadent.org.uk>

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
 tools/lib/lockdep/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile
index ce21b9429314..ed9ace59d112 100644
--- a/tools/lib/lockdep/Makefile
+++ b/tools/lib/lockdep/Makefile
@@ -101,7 +101,7 @@ include $(srctree)/tools/build/Makefile.include
 
 do_compile_shared_library =			\
 	($(print_shared_lib_compile)		\
-	$(CC) --shared $^ -o $@ -lpthread -ldl -Wl,-soname='$(@F)';$(shell ln -sf $(@F) $(@D)/liblockdep.so))
+	$(CC) $(LDFLAGS) --shared $^ -o $@ -lpthread -ldl -Wl,-soname='$(@F)';$(shell ln -sf $(@F) $(@D)/liblockdep.so))
 
 do_build_static_lib =				\
 	($(print_static_lib_build)		\
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1657444 — [tip:locking/core] tools/lib/lockdep: Use LDFLAGS

Fromtip-bot for Ben Hutchings <tipbot@zytor.com>
Date2017-06-05 11:20 +0200
Subject[tip:locking/core] tools/lib/lockdep: Use LDFLAGS
Message-ID<tOWl5-12Q-47@gated-at.bofh.it>
In reply to#1650482
Commit-ID:  d8633a32f2a466e8f03f6f06dab237ff4a1e95f2
Gitweb:     http://git.kernel.org/tip/d8633a32f2a466e8f03f6f06dab237ff4a1e95f2
Author:     Ben Hutchings <ben@decadent.org.uk>
AuthorDate: Thu, 25 May 2017 12:58:51 +0000
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 5 Jun 2017 09:28:10 +0200

tools/lib/lockdep: Use LDFLAGS

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: a.p.zijlstra@chello.nl
Link: http://lkml.kernel.org/r/20170525130005.5947-16-alexander.levin@verizon.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/lib/lockdep/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile
index ce21b94..ed9ace5 100644
--- a/tools/lib/lockdep/Makefile
+++ b/tools/lib/lockdep/Makefile
@@ -101,7 +101,7 @@ include $(srctree)/tools/build/Makefile.include
 
 do_compile_shared_library =			\
 	($(print_shared_lib_compile)		\
-	$(CC) --shared $^ -o $@ -lpthread -ldl -Wl,-soname='$(@F)';$(shell ln -sf $(@F) $(@D)/liblockdep.so))
+	$(CC) $(LDFLAGS) --shared $^ -o $@ -lpthread -ldl -Wl,-soname='$(@F)';$(shell ln -sf $(@F) $(@D)/liblockdep.so))
 
 do_build_static_lib =				\
 	($(print_static_lib_build)		\

[toc] | [prev] | [next] | [standalone]

#1650483 — [PATCH 20/21] tools: liblockdep: add dummy current_gfp_context()

From"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Date2017-05-25 15:10 +0200
Subject[PATCH 20/21] tools: liblockdep: add dummy current_gfp_context()
Message-ID<tL0GD-c1-45@gated-at.bofh.it>
In reply to#1650464
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
 tools/lib/lockdep/uinclude/linux/kernel.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/lib/lockdep/uinclude/linux/kernel.h b/tools/lib/lockdep/uinclude/linux/kernel.h
index 75ff4b1bbcac..4a31ebe1a377 100644
--- a/tools/lib/lockdep/uinclude/linux/kernel.h
+++ b/tools/lib/lockdep/uinclude/linux/kernel.h
@@ -54,5 +54,8 @@ static inline int lockdep_warn(int condition)
 #endif
 
 #define pr_err(format, ...) fprintf (stderr, format, ## __VA_ARGS__)
+#define pr_warn pr_err
+
+#define current_gfp_context(k) 0
 
 #endif
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1657431 — [tip:locking/core] tools/lib/lockdep: Add dummy current_gfp_context()

From"tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com>
Date2017-06-05 11:20 +0200
Subject[tip:locking/core] tools/lib/lockdep: Add dummy current_gfp_context()
Message-ID<tOWl4-12Q-19@gated-at.bofh.it>
In reply to#1650483
Commit-ID:  3f5a3934f4165f7f59bf8383011ed559b8acce7e
Gitweb:     http://git.kernel.org/tip/3f5a3934f4165f7f59bf8383011ed559b8acce7e
Author:     Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com>
AuthorDate: Thu, 25 May 2017 12:58:57 +0000
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 5 Jun 2017 09:28:13 +0200

tools/lib/lockdep: Add dummy current_gfp_context()

Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: a.p.zijlstra@chello.nl
Cc: ben@decadent.org.uk
Link: http://lkml.kernel.org/r/20170525130005.5947-21-alexander.levin@verizon.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/lib/lockdep/uinclude/linux/kernel.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/lib/lockdep/uinclude/linux/kernel.h b/tools/lib/lockdep/uinclude/linux/kernel.h
index 75ff4b1..4a31ebe 100644
--- a/tools/lib/lockdep/uinclude/linux/kernel.h
+++ b/tools/lib/lockdep/uinclude/linux/kernel.h
@@ -54,5 +54,8 @@ static inline int lockdep_warn(int condition)
 #endif
 
 #define pr_err(format, ...) fprintf (stderr, format, ## __VA_ARGS__)
+#define pr_warn pr_err
+
+#define current_gfp_context(k) 0
 
 #endif

[toc] | [prev] | [next] | [standalone]

#1650484 — [PATCH 18/21] tools: liblockdep: add empty __is_[module,kernel]_percpu_address

From"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Date2017-05-25 15:10 +0200
Subject[PATCH 18/21] tools: liblockdep: add empty __is_[module,kernel]_percpu_address
Message-ID<tL0GD-c1-47@gated-at.bofh.it>
In reply to#1650464
This would fix the build error caused by:

	383776fa7 ("locking/lockdep: Handle statically initialized
PER_CPU locks properly")

Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
 tools/lib/lockdep/uinclude/linux/lockdep.h | 5 +++++
 tools/lib/lockdep/uinclude/linux/module.h  | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/tools/lib/lockdep/uinclude/linux/lockdep.h b/tools/lib/lockdep/uinclude/linux/lockdep.h
index d988fba99454..f026d4545e97 100644
--- a/tools/lib/lockdep/uinclude/linux/lockdep.h
+++ b/tools/lib/lockdep/uinclude/linux/lockdep.h
@@ -51,4 +51,9 @@ static inline int debug_locks_off(void)
 #define debug_show_all_locks()
 extern void debug_check_no_locks_held(void);
 
+static __used bool __is_kernel_percpu_address(unsigned long addr, void *can_addr)
+{
+	return false;
+}
+
 #endif
diff --git a/tools/lib/lockdep/uinclude/linux/module.h b/tools/lib/lockdep/uinclude/linux/module.h
index 09c7a7be8ccc..07055db296f3 100644
--- a/tools/lib/lockdep/uinclude/linux/module.h
+++ b/tools/lib/lockdep/uinclude/linux/module.h
@@ -3,4 +3,9 @@
 
 #define module_param(name, type, perm)
 
+static inline bool __is_module_percpu_address(unsigned long addr, unsigned long *can_addr)
+{
+	return false;
+}
+
 #endif
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1657438 — [tip:locking/core] tools/lib/lockdep: Add empty __is_[module,kernel]_percpu_address

From"tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com>
Date2017-06-05 11:20 +0200
Subject[tip:locking/core] tools/lib/lockdep: Add empty __is_[module,kernel]_percpu_address
Message-ID<tOWl4-12Q-35@gated-at.bofh.it>
In reply to#1650484
Commit-ID:  3156cbaeda991f6b330dd8260d863bfad71b358e
Gitweb:     http://git.kernel.org/tip/3156cbaeda991f6b330dd8260d863bfad71b358e
Author:     Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com>
AuthorDate: Thu, 25 May 2017 12:58:55 +0000
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 5 Jun 2017 09:28:12 +0200

tools/lib/lockdep: Add empty __is_[module,kernel]_percpu_address

This would fix the build error caused by:

	383776fa7 ("locking/lockdep: Handle statically initialized
PER_CPU locks properly")

Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: a.p.zijlstra@chello.nl
Cc: ben@decadent.org.uk
Link: http://lkml.kernel.org/r/20170525130005.5947-19-alexander.levin@verizon.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/lib/lockdep/uinclude/linux/lockdep.h | 5 +++++
 tools/lib/lockdep/uinclude/linux/module.h  | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/tools/lib/lockdep/uinclude/linux/lockdep.h b/tools/lib/lockdep/uinclude/linux/lockdep.h
index d988fba..f026d45 100644
--- a/tools/lib/lockdep/uinclude/linux/lockdep.h
+++ b/tools/lib/lockdep/uinclude/linux/lockdep.h
@@ -51,4 +51,9 @@ static inline int debug_locks_off(void)
 #define debug_show_all_locks()
 extern void debug_check_no_locks_held(void);
 
+static __used bool __is_kernel_percpu_address(unsigned long addr, void *can_addr)
+{
+	return false;
+}
+
 #endif
diff --git a/tools/lib/lockdep/uinclude/linux/module.h b/tools/lib/lockdep/uinclude/linux/module.h
index 09c7a7b..07055db 100644
--- a/tools/lib/lockdep/uinclude/linux/module.h
+++ b/tools/lib/lockdep/uinclude/linux/module.h
@@ -3,4 +3,9 @@
 
 #define module_param(name, type, perm)
 
+static inline bool __is_module_percpu_address(unsigned long addr, unsigned long *can_addr)
+{
+	return false;
+}
+
 #endif

[toc] | [prev] | [next] | [standalone]

#1650486 — [PATCH 07/21] liblockdep: Fix 'defined but not used' warning for init_utsname()

From"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Date2017-05-25 15:10 +0200
Subject[PATCH 07/21] liblockdep: Fix 'defined but not used' warning for init_utsname()
Message-ID<tL0GD-c1-49@gated-at.bofh.it>
In reply to#1650464
From: Ben Hutchings <ben@decadent.org.uk>

We define init_utsname() as static but not inline, resulting
in a warning for every source file that includes lockdep.h but
doesn't call it.

Since it is only used by lockdep.c, define it in there.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
 tools/lib/lockdep/lockdep.c                | 10 ++++++++++
 tools/lib/lockdep/uinclude/linux/lockdep.h | 10 ----------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/tools/lib/lockdep/lockdep.c b/tools/lib/lockdep/lockdep.c
index 443acb11f907..209f967dedaa 100644
--- a/tools/lib/lockdep/lockdep.c
+++ b/tools/lib/lockdep/lockdep.c
@@ -12,4 +12,14 @@ u32 prandom_u32(void)
 	abort();
 }
 
+static struct new_utsname *init_utsname(void)
+{
+	static struct new_utsname n = (struct new_utsname) {
+		.release = "liblockdep",
+		.version = LIBLOCKDEP_VERSION,
+	};
+
+	return &n;
+}
+
 #include "../../../kernel/locking/lockdep.c"
diff --git a/tools/lib/lockdep/uinclude/linux/lockdep.h b/tools/lib/lockdep/uinclude/linux/lockdep.h
index d1079034a14d..c157242e0417 100644
--- a/tools/lib/lockdep/uinclude/linux/lockdep.h
+++ b/tools/lib/lockdep/uinclude/linux/lockdep.h
@@ -44,16 +44,6 @@ static inline int debug_locks_off(void)
 #define atomic_t unsigned long
 #define atomic_inc(x) ((*(x))++)
 
-static struct new_utsname *init_utsname(void)
-{
-	static struct new_utsname n = (struct new_utsname) {
-		.release = "liblockdep",
-		.version = LIBLOCKDEP_VERSION,
-	};
-
-	return &n;
-}
-
 #define print_tainted() ""
 #define static_obj(x) 1
 
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1657410 — [tip:locking/core] tools/lib/lockdep: Fix 'defined but not used' warning for init_utsname()

Fromtip-bot for Ben Hutchings <tipbot@zytor.com>
Date2017-06-05 11:10 +0200
Subject[tip:locking/core] tools/lib/lockdep: Fix 'defined but not used' warning for init_utsname()
Message-ID<tOWbo-Zl-9@gated-at.bofh.it>
In reply to#1650486
Commit-ID:  1baa75406ecc2d77c9e6ecf45a707838a5bf7f29
Gitweb:     http://git.kernel.org/tip/1baa75406ecc2d77c9e6ecf45a707838a5bf7f29
Author:     Ben Hutchings <ben@decadent.org.uk>
AuthorDate: Thu, 25 May 2017 12:58:39 +0000
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 5 Jun 2017 09:28:06 +0200

tools/lib/lockdep: Fix 'defined but not used' warning for init_utsname()

We define init_utsname() as static but not inline, resulting
in a warning for every source file that includes lockdep.h but
doesn't call it.

Since it is only used by lockdep.c, define it in there.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: a.p.zijlstra@chello.nl
Link: http://lkml.kernel.org/r/20170525130005.5947-8-alexander.levin@verizon.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/lib/lockdep/lockdep.c                | 10 ++++++++++
 tools/lib/lockdep/uinclude/linux/lockdep.h | 10 ----------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/tools/lib/lockdep/lockdep.c b/tools/lib/lockdep/lockdep.c
index 443acb1..209f967 100644
--- a/tools/lib/lockdep/lockdep.c
+++ b/tools/lib/lockdep/lockdep.c
@@ -12,4 +12,14 @@ u32 prandom_u32(void)
 	abort();
 }
 
+static struct new_utsname *init_utsname(void)
+{
+	static struct new_utsname n = (struct new_utsname) {
+		.release = "liblockdep",
+		.version = LIBLOCKDEP_VERSION,
+	};
+
+	return &n;
+}
+
 #include "../../../kernel/locking/lockdep.c"
diff --git a/tools/lib/lockdep/uinclude/linux/lockdep.h b/tools/lib/lockdep/uinclude/linux/lockdep.h
index d107903..c157242 100644
--- a/tools/lib/lockdep/uinclude/linux/lockdep.h
+++ b/tools/lib/lockdep/uinclude/linux/lockdep.h
@@ -44,16 +44,6 @@ static inline int debug_locks_off(void)
 #define atomic_t unsigned long
 #define atomic_inc(x) ((*(x))++)
 
-static struct new_utsname *init_utsname(void)
-{
-	static struct new_utsname n = (struct new_utsname) {
-		.release = "liblockdep",
-		.version = LIBLOCKDEP_VERSION,
-	};
-
-	return &n;
-}
-
 #define print_tainted() ""
 #define static_obj(x) 1

[toc] | [prev] | [next] | [standalone]

#1651111

FromIngo Molnar <mingo@kernel.org>
Date2017-05-26 09:00 +0200
Message-ID<tLho6-2vy-7@gated-at.bofh.it>
In reply to#1650464
* Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:

>  MAINTAINERS                                    |   2 +-
>  tools/Makefile                                 |   8 +++--
>  tools/include/linux/bitops.h                   |  10 ++++++
>  tools/include/linux/err.h                      |   5 +++
>  tools/include/linux/jhash.h                    | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tools/include/linux/sched/clock.h              |   0
>  tools/include/linux/sched/mm.h                 |   0
>  tools/include/linux/sched/task.h               |   0
>  tools/include/linux/unaligned/packed_struct.h  |  46 +++++++++++++++++++++++++++
>  tools/lib/lockdep/Makefile                     |   9 +++---
>  tools/lib/lockdep/lockdep.c                    |  17 ++++++++++
>  tools/lib/lockdep/preload.c                    |   3 +-
>  tools/lib/lockdep/run_tests.sh                 |   8 ++---
>  tools/lib/lockdep/uinclude/linux/bitops.h      |   3 --
>  tools/lib/lockdep/uinclude/linux/compiler.h    |   2 ++
>  tools/lib/lockdep/uinclude/linux/debug_locks.h |   2 +-
>  tools/lib/lockdep/uinclude/linux/irqflags.h    |   8 ++---
>  tools/lib/lockdep/uinclude/linux/kallsyms.h    |   3 +-
>  tools/lib/lockdep/uinclude/linux/kernel.h      |  20 ++++++++++--
>  tools/lib/lockdep/uinclude/linux/lockdep.h     |  26 ++++++++--------
>  tools/lib/lockdep/uinclude/linux/module.h      |   5 +++
>  tools/lib/lockdep/uinclude/linux/rcu.h         |   2 ++
>  22 files changed, 317 insertions(+), 37 deletions(-)
>  create mode 100644 tools/include/linux/jhash.h
>  create mode 100644 tools/include/linux/sched/clock.h
>  create mode 100644 tools/include/linux/sched/mm.h
>  create mode 100644 tools/include/linux/sched/task.h
>  create mode 100644 tools/include/linux/unaligned/packed_struct.h
>  delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h

Yeah, so what needs to be fixed as well is for liblockdep to exclusively use 
tools/include/ (and extend those headers where required).

perf already uses that method and it works well.

liblockdep already uses tools/include/ in part, but even after I apply all your 
patches, there's still lib/lockdep/uinclude/ which appears to duplicate a number 
of headers.

I did a quick check - for example WARN_ON() et al is duplicated in 
tools/lib/lockdep/uinclude/linux/kernel.h.

Thanks,

	Ingo

[toc] | [prev] | [next] | [standalone]

#1651299

From"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Date2017-05-26 13:00 +0200
Message-ID<tLl8m-4P6-1@gated-at.bofh.it>
In reply to#1651111
On Fri, May 26, 2017 at 08:52:52AM +0200, Ingo Molnar wrote:
> 
> * Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:
> 
> >  MAINTAINERS                                    |   2 +-
> >  tools/Makefile                                 |   8 +++--
> >  tools/include/linux/bitops.h                   |  10 ++++++
> >  tools/include/linux/err.h                      |   5 +++
> >  tools/include/linux/jhash.h                    | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  tools/include/linux/sched/clock.h              |   0
> >  tools/include/linux/sched/mm.h                 |   0
> >  tools/include/linux/sched/task.h               |   0
> >  tools/include/linux/unaligned/packed_struct.h  |  46 +++++++++++++++++++++++++++
> >  tools/lib/lockdep/Makefile                     |   9 +++---
> >  tools/lib/lockdep/lockdep.c                    |  17 ++++++++++
> >  tools/lib/lockdep/preload.c                    |   3 +-
> >  tools/lib/lockdep/run_tests.sh                 |   8 ++---
> >  tools/lib/lockdep/uinclude/linux/bitops.h      |   3 --
> >  tools/lib/lockdep/uinclude/linux/compiler.h    |   2 ++
> >  tools/lib/lockdep/uinclude/linux/debug_locks.h |   2 +-
> >  tools/lib/lockdep/uinclude/linux/irqflags.h    |   8 ++---
> >  tools/lib/lockdep/uinclude/linux/kallsyms.h    |   3 +-
> >  tools/lib/lockdep/uinclude/linux/kernel.h      |  20 ++++++++++--
> >  tools/lib/lockdep/uinclude/linux/lockdep.h     |  26 ++++++++--------
> >  tools/lib/lockdep/uinclude/linux/module.h      |   5 +++
> >  tools/lib/lockdep/uinclude/linux/rcu.h         |   2 ++
> >  22 files changed, 317 insertions(+), 37 deletions(-)
> >  create mode 100644 tools/include/linux/jhash.h
> >  create mode 100644 tools/include/linux/sched/clock.h
> >  create mode 100644 tools/include/linux/sched/mm.h
> >  create mode 100644 tools/include/linux/sched/task.h
> >  create mode 100644 tools/include/linux/unaligned/packed_struct.h
> >  delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h
> 
> Yeah, so what needs to be fixed as well is for liblockdep to exclusively use 
> tools/include/ (and extend those headers where required).
> 
> perf already uses that method and it works well.
> 
> liblockdep already uses tools/include/ in part, but even after I apply all your 
> patches, there's still lib/lockdep/uinclude/ which appears to duplicate a number 
> of headers.
> 
> I did a quick check - for example WARN_ON() et al is duplicated in 
> tools/lib/lockdep/uinclude/linux/kernel.h.

Right, and as you can see from this patchset where we added to
tools/include/ when needed and removed from lib/lockdep/uinclude,
liblockdep is slowly creeping the "right" way.

perf, like liblockdep, didn't finish the switch to exclusively use
tools/include/ yet.

I can put more work into getting it done over the next few releases,
but it's not something I see as a critical fix for the upcoming
release.

-- 

Thanks,
Sasha

[toc] | [prev] | [next] | [standalone]

#1651322

FromIngo Molnar <mingo@kernel.org>
Date2017-05-26 13:30 +0200
Message-ID<tLlBo-5fg-21@gated-at.bofh.it>
In reply to#1651299
* Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:

> Right, and as you can see from this patchset where we added to
> tools/include/ when needed and removed from lib/lockdep/uinclude,
> liblockdep is slowly creeping the "right" way.
> 
> perf, like liblockdep, didn't finish the switch to exclusively use
> tools/include/ yet.
> 
> I can put more work into getting it done over the next few releases,
> but it's not something I see as a critical fix for the upcoming
> release.

Since liblockdep was broken for an extended period of time I'd really
like to see this fixed before I apply any more patches.

Thanks,

	Ingo

[toc] | [prev] | [next] | [standalone]

#1651338

From"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Date2017-05-26 13:50 +0200
Message-ID<tLlUJ-5nB-9@gated-at.bofh.it>
In reply to#1651322
On Fri, May 26, 2017 at 01:21:51PM +0200, Ingo Molnar wrote:
> 
> * Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:
> 
> > Right, and as you can see from this patchset where we added to
> > tools/include/ when needed and removed from lib/lockdep/uinclude,
> > liblockdep is slowly creeping the "right" way.
> > 
> > perf, like liblockdep, didn't finish the switch to exclusively use
> > tools/include/ yet.
> > 
> > I can put more work into getting it done over the next few releases,
> > but it's not something I see as a critical fix for the upcoming
> > release.
> 
> Since liblockdep was broken for an extended period of time I'd really
> like to see this fixed before I apply any more patches.

What does the build breakage has to do with converting the way we
use headers? There's no broken functionality as far as I can tell,
so why is the header thing defined as a "fix" to begin with?

I also don't see a single tools/ project to exclusively use tools/include
at this point.

Would you rather keep liblockdep broken for the next couple of months
until this is sorted? I really doubt I could get something (+ enough
time to soak in -next) for v4.13, so we're looking at v4.14 at the
earliest.

-- 

Thanks,
Sasha

[toc] | [prev] | [next] | [standalone]

#1652065

FromIngo Molnar <mingo@kernel.org>
Date2017-05-28 11:20 +0200
Message-ID<tM2wG-8pZ-13@gated-at.bofh.it>
In reply to#1651338
* Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:

> On Fri, May 26, 2017 at 01:21:51PM +0200, Ingo Molnar wrote:
> > 
> > * Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:
> > 
> > > Right, and as you can see from this patchset where we added to
> > > tools/include/ when needed and removed from lib/lockdep/uinclude,
> > > liblockdep is slowly creeping the "right" way.
> > > 
> > > perf, like liblockdep, didn't finish the switch to exclusively use
> > > tools/include/ yet.
> > > 
> > > I can put more work into getting it done over the next few releases,
> > > but it's not something I see as a critical fix for the upcoming
> > > release.
> > 
> > Since liblockdep was broken for an extended period of time I'd really
> > like to see this fixed before I apply any more patches.
> 
> What does the build breakage has to do with converting the way we use headers?  
> There's no broken functionality as far as I can tell, so why is the header thing 
> defined as a "fix" to begin with?

liblockdep was essentially build-broken for almost a year.

I worry about and question liblockdep's general maintainability and as a 
maintainer of lockdep I can see only two options going forward: either it's 
cleaned up for good (going beyond what is needed to fix the build failures and 
warnings), or we remove it (with the option of reintroducing it if/when it's clean 
enough).

I.e. the quality bar has increased.

> I also don't see a single tools/ project to exclusively use tools/include at 
> this point.
> 
> Would you rather keep liblockdep broken for the next couple of months until this 
> is sorted? I really doubt I could get something (+ enough time to soak in -next) 
> for v4.13, so we're looking at v4.14 at the earliest.

No, if it does not improve then I'd rather remove it, and re-add it at a later 
date if/when it's clean enough.

Thanks,

	Ingo

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web