Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1651111
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 00/21] liblockdep fixes for v4.12 |
| Date | 2017-05-26 09:00 +0200 |
| Message-ID | <tLho6-2vy-7@gated-at.bofh.it> (permalink) |
| References | <tL0wV-8li-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
* Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote: > MAINTAINERS | 2 +- > tools/Makefile | 8 +++-- > tools/include/linux/bitops.h | 10 ++++++ > tools/include/linux/err.h | 5 +++ > tools/include/linux/jhash.h | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tools/include/linux/sched/clock.h | 0 > tools/include/linux/sched/mm.h | 0 > tools/include/linux/sched/task.h | 0 > tools/include/linux/unaligned/packed_struct.h | 46 +++++++++++++++++++++++++++ > tools/lib/lockdep/Makefile | 9 +++--- > tools/lib/lockdep/lockdep.c | 17 ++++++++++ > tools/lib/lockdep/preload.c | 3 +- > tools/lib/lockdep/run_tests.sh | 8 ++--- > tools/lib/lockdep/uinclude/linux/bitops.h | 3 -- > tools/lib/lockdep/uinclude/linux/compiler.h | 2 ++ > tools/lib/lockdep/uinclude/linux/debug_locks.h | 2 +- > tools/lib/lockdep/uinclude/linux/irqflags.h | 8 ++--- > tools/lib/lockdep/uinclude/linux/kallsyms.h | 3 +- > tools/lib/lockdep/uinclude/linux/kernel.h | 20 ++++++++++-- > tools/lib/lockdep/uinclude/linux/lockdep.h | 26 ++++++++-------- > tools/lib/lockdep/uinclude/linux/module.h | 5 +++ > tools/lib/lockdep/uinclude/linux/rcu.h | 2 ++ > 22 files changed, 317 insertions(+), 37 deletions(-) > create mode 100644 tools/include/linux/jhash.h > create mode 100644 tools/include/linux/sched/clock.h > create mode 100644 tools/include/linux/sched/mm.h > create mode 100644 tools/include/linux/sched/task.h > create mode 100644 tools/include/linux/unaligned/packed_struct.h > delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h Yeah, so what needs to be fixed as well is for liblockdep to exclusively use tools/include/ (and extend those headers where required). perf already uses that method and it works well. liblockdep already uses tools/include/ in part, but even after I apply all your patches, there's still lib/lockdep/uinclude/ which appears to duplicate a number of headers. I did a quick check - for example WARN_ON() et al is duplicated in tools/lib/lockdep/uinclude/linux/kernel.h. Thanks, Ingo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/21] liblockdep fixes for v4.12 "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:00 +0200
[PATCH 10/21] tools: add install make target for liblockdep "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:00 +0200
[tip:locking/core] tools: Add install make target for liblockdep tip-bot for Alexander Sverdlin <tipbot@zytor.com> - 2017-06-05 11:20 +0200
[PATCH 06/21] liblockdep: Fix 'set but not used' warnings "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:00 +0200
[tip:locking/core] tools/lib/lockdep: Fix 'set but not used' warnings tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:10 +0200
[PATCH 03/21] liblockdep: Define the ARRAY_SIZE() macro "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:00 +0200
[tip:locking/core] tools/lib/lockdep: Define the ARRAY_SIZE() macro tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:10 +0200
[PATCH 11/21] tools: liblockdep: Don't mix fd-based and stream IO "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/lib/lockdep: Don't mix fd-based and stream IO tip-bot for Alexander Sverdlin <tipbot@zytor.com> - 2017-06-05 11:20 +0200
[PATCH 19/21] tools include: add IS_ERR_OR_NULL to err.h "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/include: Add IS_ERR_OR_NULL to err.h "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
[PATCH 09/21] MAINTAINERS: update email for Sasha Levin "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] MAINTAINERS: Update email for Sasha Levin "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:10 +0200
[PATCH 04/21] liblockdep: Enable -Wall by default "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/lib/lockdep: Enable -Wall by default tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:10 +0200
[PATCH 12/21] tools: liblockdep: fix compilation for 4.11 "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/lib/lockdep: Fix compilation for 4.11 "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
[PATCH 21/21] tools: liblockdep: hide liblockdep output from test results "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/lib/lockdep: Hide liblockdep output from test results "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
[PATCH 14/21] tools: liblockdep: Remove double-quotes from soname "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/lib/lockdep: Remove double-quotes from soname tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:20 +0200
[PATCH 17/21] tools: liblockdep: include err.h "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/lib/lockdep: Include err.h "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
[PATCH 15/21] tools: liblockdep: Use LDFLAGS "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/lib/lockdep: Use LDFLAGS tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:20 +0200
[PATCH 20/21] tools: liblockdep: add dummy current_gfp_context() "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/lib/lockdep: Add dummy current_gfp_context() "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
[PATCH 18/21] tools: liblockdep: add empty __is_[module,kernel]_percpu_address "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/lib/lockdep: Add empty __is_[module,kernel]_percpu_address "tip-bot for Levin, Alexander (Sasha Levin)" <tipbot@zytor.com> - 2017-06-05 11:20 +0200
[PATCH 07/21] liblockdep: Fix 'defined but not used' warning for init_utsname() "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-25 15:10 +0200
[tip:locking/core] tools/lib/lockdep: Fix 'defined but not used' warning for init_utsname() tip-bot for Ben Hutchings <tipbot@zytor.com> - 2017-06-05 11:10 +0200
Re: [PATCH 00/21] liblockdep fixes for v4.12 Ingo Molnar <mingo@kernel.org> - 2017-05-26 09:00 +0200
Re: [PATCH 00/21] liblockdep fixes for v4.12 "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-26 13:00 +0200
Re: [PATCH 00/21] liblockdep fixes for v4.12 Ingo Molnar <mingo@kernel.org> - 2017-05-26 13:30 +0200
Re: [PATCH 00/21] liblockdep fixes for v4.12 "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-05-26 13:50 +0200
Re: [PATCH 00/21] liblockdep fixes for v4.12 Ingo Molnar <mingo@kernel.org> - 2017-05-28 11:20 +0200
csiph-web