Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1649070 > unrolled thread

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with  cpufreq core Eduardo Valentin <edubezval@gmail.com> - 2017-05-24 04:50 +0200
    Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with  cpufreq core Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-24 06:00 +0200
      Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with  cpufreq core Eduardo Valentin <edubezval@gmail.com> - 2017-05-24 06:10 +0200

#1649070 — Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

[Multipart message — attachments visible in raw view] — view raw

Hey,

On Tue, Apr 25, 2017 at 03:57:07PM +0530, Viresh Kumar wrote:
> Hi Guys,
> 
> The cpu_cooling driver is designed to use CPU frequency scaling to avoid
> high thermal states for a platform. But it wasn't glued really well with
> cpufreq core. For example clipped-cpus is copied from the policy
> structure and its much better to use the policy->cpus (or related_cpus)
> fields directly as they may have got updated. Not that things were
> broken before this series, but they can be optimized a bit more.
> 
> This series tries to improve interactions between cpufreq core and
> cpu_cooling driver and does some fixes/cleanups to the cpu_cooling
> driver.
> 
> I have tested it on ARM 32 (exynos) and 64 bit (hikey) boards (haven't
> tested the power specific bits).
> 
> Lukasz from ARM has been very generous in testing and finding out few
> bugs in the earlier versions and getting those fixed.  He has
> successfully tested the new version on his ARM big LITTLE Juno board.
> 
> Pushed here as well:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git thermal/cooling
> 
> V3->V4:


Took this version into my -linus branch for the next merge window.
Including the patch to remove the checkpatch warning. But please send
an extra patch to fix the style pointed on patch 8.

[toc] | [next] | [standalone]

#1649079

On 23-05-17, 19:41, Eduardo Valentin wrote:
> Hey,
> 
> On Tue, Apr 25, 2017 at 03:57:07PM +0530, Viresh Kumar wrote:
> > Hi Guys,
> > 
> > The cpu_cooling driver is designed to use CPU frequency scaling to avoid
> > high thermal states for a platform. But it wasn't glued really well with
> > cpufreq core. For example clipped-cpus is copied from the policy
> > structure and its much better to use the policy->cpus (or related_cpus)
> > fields directly as they may have got updated. Not that things were
> > broken before this series, but they can be optimized a bit more.
> > 
> > This series tries to improve interactions between cpufreq core and
> > cpu_cooling driver and does some fixes/cleanups to the cpu_cooling
> > driver.
> > 
> > I have tested it on ARM 32 (exynos) and 64 bit (hikey) boards (haven't
> > tested the power specific bits).
> > 
> > Lukasz from ARM has been very generous in testing and finding out few
> > bugs in the earlier versions and getting those fixed.  He has
> > successfully tested the new version on his ARM big LITTLE Juno board.
> > 
> > Pushed here as well:
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git thermal/cooling
> > 
> > V3->V4:
> 
> 
> Took this version into my -linus branch for the next merge window.
> Including the patch to remove the checkpatch warning. But please send
> an extra patch to fix the style pointed on patch 8.

Thanks Eduardo.

But I am not sure what's left there to be fixed :(

There were two warnings with patch 8, s/kmalloc/kmalloc_array and line
over 80 columns and both were fixed by the patch I sent separately.

-- 
viresh

[toc] | [prev] | [next] | [standalone]

#1649084

[Multipart message — attachments visible in raw view] — view raw

Viresh,

On Wed, May 24, 2017 at 09:23:52AM +0530, Viresh Kumar wrote:
> On 23-05-17, 19:41, Eduardo Valentin wrote:
> > Hey,
> > 
> > On Tue, Apr 25, 2017 at 03:57:07PM +0530, Viresh Kumar wrote:
> > > Hi Guys,
> > > 
> > > The cpu_cooling driver is designed to use CPU frequency scaling to avoid
> > > high thermal states for a platform. But it wasn't glued really well with
> > > cpufreq core. For example clipped-cpus is copied from the policy
> > > structure and its much better to use the policy->cpus (or related_cpus)
> > > fields directly as they may have got updated. Not that things were
> > > broken before this series, but they can be optimized a bit more.
> > > 
> > > This series tries to improve interactions between cpufreq core and
> > > cpu_cooling driver and does some fixes/cleanups to the cpu_cooling
> > > driver.
> > > 
> > > I have tested it on ARM 32 (exynos) and 64 bit (hikey) boards (haven't
> > > tested the power specific bits).
> > > 
> > > Lukasz from ARM has been very generous in testing and finding out few
> > > bugs in the earlier versions and getting those fixed.  He has
> > > successfully tested the new version on his ARM big LITTLE Juno board.
> > > 
> > > Pushed here as well:
> > > 
> > > git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git thermal/cooling
> > > 
> > > V3->V4:
> > 
> > 
> > Took this version into my -linus branch for the next merge window.
> > Including the patch to remove the checkpatch warning. But please send
> > an extra patch to fix the style pointed on patch 8.
> 
> Thanks Eduardo.
> 
> But I am not sure what's left there to be fixed :(
> 
> There were two warnings with patch 8, s/kmalloc/kmalloc_array and line
> over 80 columns and both were fixed by the patch I sent separately.

You are right, you are done here. This was probably a bug in my script
showing old checkpatch results on patch 8, somehow.

Sorry for the noise.

> 
> -- 
> viresh

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web