Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1649842 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2017-05-24 20:10 +0200 |
| Last post | 2017-05-27 20:50 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] Blackfin: Adjustments for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 20:10 +0200
[PATCH 2/2] blackfin: Delete an error message for a failed memory allocation in isram_test_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 20:10 +0200
[PATCH 1/2] blackfin: Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 20:10 +0200
Re: [PATCH 1/2] blackfin: Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter() Al Viro <viro@ZenIV.linux.org.uk> - 2017-05-27 20:50 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-24 20:10 +0200 |
| Subject | [PATCH 0/2] Blackfin: Adjustments for two function implementations |
| Message-ID | <tKITn-5Hs-7@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Wed, 24 May 2017 20:00:02 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter() Delete an error message for a failed memory allocation in isram_test_init() arch/blackfin/mach-common/pm.c | 4 +--- arch/blackfin/mm/isram-driver.c | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) -- 2.13.0
[toc] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-24 20:10 +0200 |
| Subject | [PATCH 2/2] blackfin: Delete an error message for a failed memory allocation in isram_test_init() |
| Message-ID | <tKITn-5Hs-5@gated-at.bofh.it> |
| In reply to | #1649842 |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 May 2017 19:39:32 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/blackfin/mm/isram-driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/blackfin/mm/isram-driver.c b/arch/blackfin/mm/isram-driver.c
index aaa1e64b753b..4221b07a61dc 100644
--- a/arch/blackfin/mm/isram-driver.c
+++ b/arch/blackfin/mm/isram-driver.c
@@ -374,6 +374,5 @@ static __init int isram_test_init(void)
if (!sdram) {
sram_free(l1inst);
- pr_warning("SKIP: could not allocate sdram\n");
return 0;
}
--
2.13.0
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-24 20:10 +0200 |
| Subject | [PATCH 1/2] blackfin: Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter() |
| Message-ID | <tKITo-5Hs-13@gated-at.bofh.it> |
| In reply to | #1649842 |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 May 2017 19:29:25 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/blackfin/mach-common/pm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/blackfin/mach-common/pm.c b/arch/blackfin/mach-common/pm.c
index 5ece38a5b758..f4d442b7a1a1 100644
--- a/arch/blackfin/mach-common/pm.c
+++ b/arch/blackfin/mach-common/pm.c
@@ -151,10 +151,8 @@ int bfin_pm_suspend_mem_enter(void)
+ L1_DATA_B_LENGTH + L1_SCRATCH_LENGTH,
GFP_ATOMIC);
- if (memptr == NULL) {
- panic("bf53x_suspend_l1_mem malloc failed");
+ if (!memptr)
return -ENOMEM;
- }
#ifndef CONFIG_BF60x
wakeup = bfin_read_VR_CTL() & ~FREQ;
--
2.13.0
[toc] | [prev] | [next] | [standalone]
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Date | 2017-05-27 20:50 +0200 |
| Subject | Re: [PATCH 1/2] blackfin: Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter() |
| Message-ID | <tLOWJ-7Id-1@gated-at.bofh.it> |
| In reply to | #1649845 |
On Wed, May 24, 2017 at 08:03:45PM +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 24 May 2017 19:29:25 +0200 > > Omit an extra message for a memory allocation failure in this function. That's no extra message, that's "won't continue past that point if it happens". > This issue was detected by using the Coccinelle software. ... which absolves you of any need to think, presumably.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web