Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1649845
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] blackfin: Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter() |
| Date | 2017-05-24 20:10 +0200 |
| Message-ID | <tKITo-5Hs-13@gated-at.bofh.it> (permalink) |
| References | <tKITn-5Hs-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 May 2017 19:29:25 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/blackfin/mach-common/pm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/blackfin/mach-common/pm.c b/arch/blackfin/mach-common/pm.c
index 5ece38a5b758..f4d442b7a1a1 100644
--- a/arch/blackfin/mach-common/pm.c
+++ b/arch/blackfin/mach-common/pm.c
@@ -151,10 +151,8 @@ int bfin_pm_suspend_mem_enter(void)
+ L1_DATA_B_LENGTH + L1_SCRATCH_LENGTH,
GFP_ATOMIC);
- if (memptr == NULL) {
- panic("bf53x_suspend_l1_mem malloc failed");
+ if (!memptr)
return -ENOMEM;
- }
#ifndef CONFIG_BF60x
wakeup = bfin_read_VR_CTL() & ~FREQ;
--
2.13.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] Blackfin: Adjustments for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 20:10 +0200
[PATCH 2/2] blackfin: Delete an error message for a failed memory allocation in isram_test_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 20:10 +0200
[PATCH 1/2] blackfin: Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 20:10 +0200
Re: [PATCH 1/2] blackfin: Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter() Al Viro <viro@ZenIV.linux.org.uk> - 2017-05-27 20:50 +0200
csiph-web