Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1643726 > unrolled thread
| Started by | Manny Vindiola <mannyv@gmail.com> |
|---|---|
| First post | 2017-05-18 03:50 +0200 |
| Last post | 2017-05-18 22:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c Manny Vindiola <mannyv@gmail.com> - 2017-05-18 03:50 +0200
Re: [PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c Alan Cox <alan@linux.intel.com> - 2017-05-18 18:40 +0200
Re: [PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c Greg KH <gregkh@linuxfoundation.org> - 2017-05-18 22:50 +0200
| From | Manny Vindiola <mannyv@gmail.com> |
|---|---|
| Date | 2017-05-18 03:50 +0200 |
| Subject | [PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c |
| Message-ID | <tIiJH-2DZ-1@gated-at.bofh.it> |
This is a patch to the atomisp_tpg.c file that fixes up a missing
blank line warning found by the checkpatch.pl tool
Signed-off-by: Manny Vindiola <mannyv@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
index 996d1bd..48b9604 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
@@ -56,6 +56,7 @@ static int tpg_set_fmt(struct v4l2_subdev *sd,
struct v4l2_subdev_format *format)
{
struct v4l2_mbus_framefmt *fmt = &format->format;
+
if (format->pad)
return -EINVAL;
/* only raw8 grbg is supported by TPG */
--
2.7.4
[toc] | [next] | [standalone]
| From | Alan Cox <alan@linux.intel.com> |
|---|---|
| Date | 2017-05-18 18:40 +0200 |
| Subject | Re: [PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c |
| Message-ID | <tIwD0-5eS-17@gated-at.bofh.it> |
| In reply to | #1643726 |
On Wed, 2017-05-17 at 21:48 -0400, Manny Vindiola wrote:
> This is a patch to the atomisp_tpg.c file that fixes up a missing
> blank line warning found by the checkpatch.pl tool
>
> Signed-off-by: Manny Vindiola <mannyv@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> index 996d1bd..48b9604 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> @@ -56,6 +56,7 @@ static int tpg_set_fmt(struct v4l2_subdev *sd,
> struct v4l2_subdev_format *format)
> {
> struct v4l2_mbus_framefmt *fmt = &format->format;
> +
> if (format->pad)
> return -EINVAL;
> /* only raw8 grbg is supported by TPG */
The TODO fille for this driver specifically says not to send formatting
patches at this point.
There is no point making trivial spacing changes in code that needs
lots of real work. It's like polishing your car when the doors have
fallen off.
Alan
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-18 22:50 +0200 |
| Subject | Re: [PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c |
| Message-ID | <tIAwW-8wt-11@gated-at.bofh.it> |
| In reply to | #1644737 |
On Thu, May 18, 2017 at 05:31:20PM +0100, Alan Cox wrote:
> On Wed, 2017-05-17 at 21:48 -0400, Manny Vindiola wrote:
> > This is a patch to the atomisp_tpg.c file that fixes up a missing
> > blank line warning found by the checkpatch.pl tool
> >
> > Signed-off-by: Manny Vindiola <mannyv@gmail.com>
> > ---
> > drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> > b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> > index 996d1bd..48b9604 100644
> > --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> > +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> > @@ -56,6 +56,7 @@ static int tpg_set_fmt(struct v4l2_subdev *sd,
> > struct v4l2_subdev_format *format)
> > {
> > struct v4l2_mbus_framefmt *fmt = &format->format;
> > +
> > if (format->pad)
> > return -EINVAL;
> > /* only raw8 grbg is supported by TPG */
>
> The TODO fille for this driver specifically says not to send formatting
> patches at this point.
>
> There is no point making trivial spacing changes in code that needs
> lots of real work. It's like polishing your car when the doors have
> fallen off.
Unfortunatly, given that the code is in staging, that's not going to
happen, people are going to send cleanup patches, and that's ok. They
should be easy to merge around, it's the price for being in the tree.
thanks,
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web